🐛 Fix restore loading not working when clicked repeatedly#5311
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit bcbac25. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit bcbac25:
|
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #5311 +/- ##
=========================================
+ Coverage 0 88.80% +88.80%
=========================================
Files 0 11 +11
Lines 0 643 +643
Branches 0 239 +239
=========================================
+ Hits 0 571 +571
- Misses 0 66 +66
- Partials 0 6 +6
... and 10 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
TkDodo
left a comment
There was a problem hiding this comment.
can you please add a test that covers this scenario? Ideally, one that failed before and doesn't fail after the fix 🙏
|
Added a test @TkDodo, also verified that it fails with the same error if I remove the fix: |
Fixes #5157
Checkout this comment for a detailed description of this change fixes the issue