Skip to content

fix(ssr): transform superclass identifier#13635

Merged
patak-cat merged 1 commit into
mainfrom
fix-ssr-class-name
Jun 26, 2023
Merged

fix(ssr): transform superclass identifier#13635
patak-cat merged 1 commit into
mainfrom
fix-ssr-class-name

Conversation

@bluwy

@bluwy bluwy commented Jun 26, 2023

Copy link
Copy Markdown
Member

Description

Following up on #13572, when transforming let foo = class extends Bar {}, the Bar is not transformed to the import used. Bar is considered a superclass in the AST.

Fixed the issue by checking if Bar is a class name id and not a superclass id.

Additional context

This is causing a fail in Astro's lit element test after transpiled by esbuild:

let MyElement = class extends LitElement {

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bolt-new-by-stackblitz

Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@bluwy bluwy added p3-minor-bug An edge case that only affects very specific usage (priority) feat: ssr labels Jun 26, 2023
@patak-cat
patak-cat merged commit c5b2c8f into main Jun 26, 2023
@patak-cat
patak-cat deleted the fix-ssr-class-name branch June 26, 2023 07:54
xinxinhe1810 pushed a commit to xinxinhe1810/vite that referenced this pull request Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat: ssr p3-minor-bug An edge case that only affects very specific usage (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants