This repository was archived by the owner on Mar 17, 2026. It is now read-only.
fix: Pin @types/sinon to last compatible version#345
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #345 +/- ##
=======================================
Coverage 96.42% 96.42%
=======================================
Files 13 13
Lines 1062 1062
Branches 144 144
=======================================
Hits 1024 1024
Misses 32 32
Partials 6 6Continue to review full report at Codecov.
|
JustinBeckwith
approved these changes
Nov 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@types/sinon had an update over the weekend which broke many of our tests. The real fix is something like this, but for now, this should fix our broken CI and give us some breathing room.