This repository was archived by the owner on Mar 17, 2026. It is now read-only.
feat: update IAM protos#734
Merged
Merged
Conversation
alexander-fenster
requested review from
bcoe,
callmehiphop and
stephenplusplus
September 6, 2019 20:58
Codecov Report
@@ Coverage Diff @@
## master #734 +/- ##
=====================================
Coverage 97% 97%
=====================================
Files 14 14
Lines 867 867
Branches 182 182
=====================================
Hits 841 841
Misses 6 6
Partials 20 20Continue to review full report at Codecov.
|
callmehiphop
approved these changes
Sep 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One consequence of #730 is that it will take up to date protos for IAM. Normally, this should not be an issue, but seems there was a slight change in the return value of setting IAM policy (added
condition: nullto the result). In this PR I'm updating the protos, the generated.d.tsfiles for IAM, and system/sample tests.