Skip to content
This repository was archived by the owner on Mar 17, 2026. It is now read-only.

fix: pull emulator creds from local grpc instance#795

Merged
callmehiphop merged 1 commit into
googleapis:masterfrom
callmehiphop:emulator-creds
Oct 22, 2019
Merged

fix: pull emulator creds from local grpc instance#795
callmehiphop merged 1 commit into
googleapis:masterfrom
callmehiphop:emulator-creds

Conversation

@callmehiphop

@callmehiphop callmehiphop commented Oct 22, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #794 🦕

@callmehiphop callmehiphop requested a review from a team October 22, 2019 19:23
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 22, 2019
@bcoe bcoe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 22, 2019
@codecov

codecov Bot commented Oct 22, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #795 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #795      +/-   ##
=========================================
+ Coverage   94.49%   94.5%   +<.01%     
=========================================
  Files          15      15              
  Lines         890     891       +1     
  Branches      182     183       +1     
=========================================
+ Hits          841     842       +1     
  Misses         28      28              
  Partials       21      21
Impacted Files Coverage Δ
src/pubsub.ts 98.75% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c31507d...3ce48dd. Read the comment docs.

@callmehiphop callmehiphop merged commit 1749b62 into googleapis:master Oct 22, 2019
@rdlowrey

rdlowrey commented Oct 22, 2019

Copy link
Copy Markdown

❤️

feywind pushed a commit to feywind/nodejs-pubsub that referenced this pull request Nov 12, 2024
@AVaksman
feat: getAppProfilesStream emits (if there are any failed locations p…
dbb19fe 
…resent) decorated error with failedLocations info (googleapis#795)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@bcoe bcoe bcoe approved these changes
@stephenplusplus stephenplusplus stephenplusplus approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement. kokoro:force-run Add this label to force Kokoro to re-run the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Pubsub Emulator support seems broken in 1.1.4

5 participants

@callmehiphop @rdlowrey @bcoe @stephenplusplus @googlebot