This repository was archived by the owner on Mar 17, 2026. It is now read-only.
chore!: drop support for custom promises#970
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #970 +/- ##
=======================================
Coverage 95.26% 95.27%
=======================================
Files 22 22
Lines 10642 10621 -21
Branches 467 486 +19
=======================================
- Hits 10138 10119 -19
+ Misses 501 499 -2
Partials 3 3
Continue to review full report at Codecov.
|
stephenplusplus
approved these changes
Apr 17, 2020
Closed
This was referenced May 19, 2020
Closed
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: This change removes the
PubSub.Promiseproperty that could be used to override the default Promise implementation in node.js. In years past, this option made sense as native Promise support on the platform lagged behind. Today, the promise implementation in node.js is complete and performant.