adapt mining.capnp with interruptWait#5
Merged
Conversation
Collaborator
|
v30.2 should be out in a few days. v30.0 and v30.1 were retracted to due to a wallet bug. That's not relevant for sv2 at all, but it's probably best to bump the minimum version to v30.2 once it's out. bitcoin/bitcoin@v30.1...v30.2: includes bitcoin/bitcoin#33511 |
Member
|
Looks good to me. As far as versioning I think this |
rustaceanrob
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bitcoin Core branches
masterand30.xnow have a newBlockTemplate.interruptWaitthat's going to be needed for stratum-mining/sv2-apps#81, which aims to remove some workarounds for some bugs that were found on
v30and patched onv30.1+my WIP is currently pointing to our fork https://github.com/stratum-mining/bitcoin-capnp-types, so this PR aims to allow us to eventually switch back to using this repo as source-of-truth
also, I believe some kind of versioning system should be considered here, as proposed on #4