Skip to content

chore: fix some typos#3891

Merged
jshier merged 1 commit into
Alamofire:masterfrom
Sajjon:cyon_fix_typos
Sep 14, 2024
Merged

chore: fix some typos#3891
jshier merged 1 commit into
Alamofire:masterfrom
Sajjon:cyon_fix_typos

Conversation

@Sajjon

@Sajjon Sajjon commented Sep 1, 2024

Copy link
Copy Markdown
Contributor

Goals ⚽

Fix some typos.

Testing Details 🔍

Installed firewalk, started it and ran swift test - tests passing.

@jshier

jshier commented Sep 1, 2024

Copy link
Copy Markdown
Contributor

Thanks for these! This all looks good, but you can remove the changes to the docs files, those are generated from the inline docs in the code, so they'll update with the fixes when I do another release.

@vivoxfold3

Copy link
Copy Markdown

⚠️⚠️⚠️Caution⚠️⚠️⚠️

This user is attempting to execute the first step of a supply chain attack, attempting to break free from the 'first-time contributor' status. The user opened a similar PR in all other repositories on the same day. He also stole pictures of other users to make them look like real people.

There are still hundreds of submissions like this, and they can be fixed at once. They will be submitted in multiple batches, and this is one part of them

@Sajjon

Sajjon commented Sep 9, 2024

Copy link
Copy Markdown
Contributor Author

@jshier Here are some context:

I informed lots of repos that Github user "vivoxfold3" had suspicous activity:

  1. has no sources (only forks)
  2. no profile photo
  3. no followers
  4. no bio
  5. forks ~10 crypto libs or repos used by crypto libs / wallets all within the same hour
  6. makes trivial contributions and tries to "counterfeit" a GPG signature by writing "Signed off by"
  7. ignores PR templates

hoprnet/hoprnet#6482 (comment)

"Unreasonable accusations from persecuted delusional patients"

Whatever that means? Obvious bad translation service.

==================

The difference between you vivoxfold3 and me is that I:

  1. Have many of SOURCE repos (not forks) with many stars
  2. My Github User is over 10 years old
  3. I have profile photo
  4. I have 100 followers
  5. I have a bio
  6. I have many verified email addresses
  7. I'm a Github PRO user
  8. I do in fact work in the crypto industry, unlike you doing trivial PRs intro 10 different crypto libs...
  9. My contributions fixing typos are non-trivial - often spent 1-3 hours per

@jshier

jshier commented Sep 9, 2024

Copy link
Copy Markdown
Contributor

Yeah, it was rather strange, especially since I'm pretty sure you've made PRs here before. Thanks.

@jshier

jshier commented Sep 14, 2024

Copy link
Copy Markdown
Contributor

I'll go ahead and merge, but the Jazzy and doc updates will simply be overwritten when I update the docs next.

@jshier jshier merged commit ba3dc43 into Alamofire:master Sep 14, 2024
@jshier jshier added this to the 5.10.0 milestone Oct 13, 2024
prongbang pushed a commit to prongbang/Alamofire that referenced this pull request May 23, 2025
### Goals ⚽
Fix some typos.

### Testing Details 🔍
Installed firewalk, started it and ran `swift test` - tests passing.
richtunnel pushed a commit to richtunnel/Alamofire that referenced this pull request Feb 6, 2026
### Goals ⚽
Fix some typos.

### Testing Details 🔍
Installed firewalk, started it and ran `swift test` - tests passing.
richtunnel added a commit to richtunnel/Alamofire that referenced this pull request Feb 7, 2026
### Goals ⚽
Fix some typos.

### Testing Details 🔍
Installed firewalk, started it and ran `swift test` - tests passing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants