Skip to content

RICH: make local Z the radial axis for radiator and photosensor tiles#15503

Merged
shahor02 merged 3 commits into
AliceO2Group:devfrom
altsybee:dev
Jun 11, 2026
Merged

RICH: make local Z the radial axis for radiator and photosensor tiles#15503
shahor02 merged 3 commits into
AliceO2Group:devfrom
altsybee:dev

Conversation

@altsybee

@altsybee altsybee commented Jun 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

In RICHRing.cxx the TGeoArb8 solids for the radiator tiles (radTile_*) and photosensor tiles (RICHPhotoTile) are redefined so their thin (radial) dimension is now the local Z axis, pointing radially outward from the IP, instead of local X. The placement rotation is changed from RotateY(-thetaBDeg) to RotateY(90 - thetaBDeg) to compensate the X→Z swap. The tiles therefore stay in exactly the same physical position — only the local frame is relabeled — which lets downstream tooling (e.g. ACTS) use the local Z = surface-normal convention directly.

argonSector_* is left unchanged, since its gap dimension is already on local Z.

Verified numerically that the 8 world-space corners of every tile are identical before and after (zero displacement).
(Note that any code relying on the previous local-axis convention should be rechecked.)

@NNicassio99

@njacazio

njacazio commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

@NNicassio99

@NNicassio99

NNicassio99 commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

I confirm everything is ok. This can be merged.

@alibuild

alibuild commented Jun 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI_slc9 for 599f0d5 at 2026-06-11 06:11:

## sw/BUILD/O2Physics-latest/log
CMake Error at /sw/slc9_x86-64/CMake/v4.1.4-2/share/cmake-4.1/Modules/CMakeTestCCompiler.cmake:67 (message):
    ninja: build stopped: subcommand failed.


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/7f091b9aa35cdb6318c0a1a3106a52db6632721c/slc9_x86-64/o2checkcode/1.0-local9/etc/modulefiles
++ alibuild-generate-module
+ HAS_BIN=
+ HAS_LIB=
+ HAS_CMAKE=
+ HAS_ROOT=
+ '[' 0 '!=' 0 ']'
+ cat
+ printf 'if ![ is-loaded '\''BASE/1.0'\'' ] {\n module load BASE/1.0\n}'
+ echo 'BUILD_REQUIRES=CMake alibuild-recipe-tools defaults-release'
BUILD_REQUIRES=CMake alibuild-recipe-tools defaults-release
+ FULL_BUILD_REQUIRES='FairCMakeModules CMake googlebenchmark Python-modules-list alibuild-recipe-tools json-c Alice-GRID-Utils O2-customization pytorch_cpuinfo UUID double-conversion MPFR defaults-release date safe_int bz2 ninja ninja-fortran'
+ echo 'FULL_BUILD_REQUIRES=FairCMakeModules CMake googlebenchmark Python-modules-list alibuild-recipe-tools json-c Alice-GRID-Utils O2-customization pytorch_cpuinfo UUID double-conversion MPFR defaults-release date safe_int bz2 ninja ninja-fortran'
FULL_BUILD_REQUIRES=FairCMakeModules CMake googlebenchmark Python-modules-list alibuild-recipe-tools json-c Alice-GRID-Utils O2-customization pytorch_cpuinfo UUID double-conversion MPFR defaults-release date safe_int bz2 ninja ninja-fortran
++ cut -f1 -d=
++ env
++ grep -v '^DEFAULT_'
++ grep -v PKGREVISION
++ grep -v ALIBUILD_RECIPE_TOOLS
++ grep REVISION
++ sed -e s/_REVISION//
+ for x in $(env | cut -f1 -d= | grep -v "^DEFAULT_" | grep -v PKGREVISION | grep -v ALIBUILD_RECIPE_TOOLS | grep REVISION | sed -e 's/_REVISION//')
++ eval 'echo $LIBFFI_REVISION'
+++ echo 10
+ REVISION_VALUE=10
++ eval 'echo $LIBFFI_VERSION'
+++ echo v3.2.1-alice1
+ VERSION_VALUE=v3.2.1-alice1
++ eval 'echo $LIBFFI_ROOT'
+++ echo /sw/slc9_x86-64/libffi/v3.2.1-alice1-10
+ ROOT_PATH_VALUE=/sw/slc9_x86-64/libffi/v3.2.1-alice1-10
+ '[' -z 10 ']'
+ echo 'FairCMakeModules CMake googlebenchmark Python-modules-list alibuild-recipe-tools json-c Alice-GRID-Utils O2-customization pytorch_cpuinfo UUID double-conversion MPFR defaults-release date safe_int bz2 ninja ninja-fortran'
+ tr '[:lower:]' '[:upper:]'
+ tr - _
+ tr ' ' '\n'
[0 more errors; see full log]

Full log here.

@njacazio njacazio enabled auto-merge (squash) June 11, 2026 10:57
@shahor02 shahor02 disabled auto-merge June 11, 2026 15:16
@shahor02 shahor02 merged commit f50077d into AliceO2Group:dev Jun 11, 2026
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@njacazio njacazio njacazio approved these changes

@mconcas mconcas Awaiting requested review from mconcas mconcas is a code owner

@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@altsybee @njacazio @NNicassio99 @alibuild @shahor02