Fix testnet WIF for derived addresses and bip47#49
Merged
Conversation
Collaborator
|
@ottosch thanks for the contribution and sorry for the slow response. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I noticed the tool was always displaying WIF in mainnet format (prefix K/L). Changing to display testnet format (prefix c) when testnet is selected.
I noticed, though, the "Seed Generation/Input" group doesn't have network selection, so the "Root WIF" field is always in mainnet format.
Also, in BIP47, it seems to me the regtest option could be removed as it looks like it's the same as testnet.