feat: introduce riscv64 to linux and musllinux builds by eshattow · Pull Request #620 · Bluetooth-Devices/dbus-fast

eshattow · 2026-04-29T07:08:42Z

Adding RISC-V to build and publish, depends on (#619 tracking issue) use of https://riseproject-dev.github.io/riscv-runner/

codecov · 2026-04-29T07:10:27Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.84%. Comparing base (e93c3e0) to head (249443b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #620      +/-   ##
==========================================
- Coverage   89.90%   89.84%   -0.06%     
==========================================
  Files          29       29              
  Lines        3527     3527              
  Branches      606      606              
==========================================
- Hits         3171     3169       -2     
- Misses        211      212       +1     
- Partials      145      146       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codspeed-hq · 2026-04-29T07:11:51Z

Merging this PR will not alter performance

✅ 6 untouched benchmarks

_{Comparing eshattow:riscv64 (249443b) with main (e93c3e0)¹}

No successful run was found on main (fdd89a8) during the generation of this report, so e93c3e0 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

Copilot

Pull request overview

Introduces a RISC-V (riscv64) build target into the wheel build workflow so Linux and musllinux wheels can be produced for that architecture.

Changes:

Add ubuntu-24.04-riscv to the build_wheels job matrix.
Configure CIBW_ARCHS_LINUX to select riscv64 when running on the RISC-V runner.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

bdraco · 2026-05-17T16:58:37Z

@bluetoothbot review

bluetoothbot · 2026-05-17T17:28:37Z

PR Review — feat: introduce riscv64 to linux and musllinux builds

Solid PR overall. The QEMU + per-Python-version split is the right approach for slow emulated riscv64 builds, action versions are SHA-pinned (including the explicit tonistiigi/binfmt:qemu-v8.1.5 workaround for the documented binfmt issues), and the rewritten CIBW_ARCHS_LINUX expression (arm && 'aarch64') || matrix.qemu || 'auto' correctly resolves for all three branches. The artifact name now includes qemu/pyver, so 12 new riscv64 rows produce distinct artifacts. build_wheels is gated on a successful release, so the extra ~30min × 12 QEMU runs only land on release runs, not every PR.

The one real concern is cp314t-riscv64 — free-threaded Python under QEMU on a recently-supported architecture is fragile and could break a release if cibuildwheel can't find a working image. Recommend confirming that lane works before merging, or omitting cp314t initially. The other two items are purely cosmetic (trailing dashes/spaces in artifact and job names).

Note: this PR can't validate itself — build_wheels only runs post-release, so the first riscv64 build will happen on the next release after merge. Worth keeping an eye on that release run.

🟡 Important

1. cp314t-riscv64 may not have a working manylinux/musllinux image (`.github/workflows/ci.yml`, L236)

Free-threaded Python 3.14 (cp314t) support across architectures is still maturing — pypa/manylinux currently lists manylinux_2_39_riscv64 as the riscv64 image, but its cp314t free-threaded wheel build under QEMU is not as well-exercised as the other arches. If cibuildwheel can't find a cp314t-riscv64 image (or build fails under QEMU), these two matrix cells (musllinux + "") will fail and block the release artifact aggregation step.

Since build_wheels runs only after release succeeds, a failure here means a published PyPI release with missing riscv64 cp314t wheels (or worse, a failed upload_pypi if the job is required). Consider either: (a) omitting cp314t initially and adding it once upstream support is confirmed, or (b) confirming locally with docker run --platform linux/riscv64 quay.io/pypa/musllinux_1_2_riscv64 … that a free-threaded cpython is present before merging. Worth verifying since you can't actually exercise these matrix rows from this PR — build_wheels is gated on needs.release.outputs.released == 'true'.

          - {
              os: ubuntu-latest,
              qemu: riscv64,
              musl: "musllinux",
              pyver: cp314t,
            }

🟢 Suggestions

1. Artifact names gain stray empty fields for non-QEMU rows (`.github/workflows/ci.yml`, L283)

For the original (non-riscv64) matrix entries — where matrix.qemu and matrix.pyver are "" — the artifact name now expands to e.g. wheels-ubuntu-24.04-arm-musllinux-- (two trailing dashes) rather than the previous wheels-ubuntu-24.04-arm-musllinux. This is purely cosmetic and the upload_pypi step uses pattern: wheels-* with merge-multiple: true, so functionality is unaffected. If you want clean artifact names, you could conditionally suffix only when set, e.g. wheels-${{ matrix.os }}-${{ matrix.musl }}${{ matrix.qemu && format('-{0}', matrix.qemu) || '' }}${{ matrix.pyver && format('-{0}', matrix.pyver) || '' }}. Not blocking — feel free to leave as-is.

          name: wheels-${{ matrix.os }}-${{ matrix.musl }}-${{ matrix.qemu }}-${{ matrix.pyver }}

2. Job display name has trailing empty placeholders (`.github/workflows/ci.yml`, L196)

For non-riscv64 rows, the name renders as e.g. Build wheels on ubuntu-24.04-arm musllinux (two trailing spaces). Same fix idea as the artifact name — conditional formatting — but again purely cosmetic. As a side benefit, this PR removes the stale with arch ${{ matrix.arch }} placeholder that was never bound to a matrix dimension, which was flagged by Copilot in an earlier review pass.

    name: Build wheels on ${{ matrix.os }} ${{ matrix.musl }} ${{ matrix.qemu }} ${{ matrix.pyver }}

Checklist

No hardcoded secrets or credentials
Action versions pinned to SHAs
QEMU image pinned to a known-good version
CIBW_ARCHS_LINUX expression covers all matrix branches
Artifact names disambiguate across new matrix cells
Free-threaded (cp314t) riscv64 build viability confirmed — warning ＃1
No regression in existing aarch64/x86_64/macOS rows
Build cost contained (gated on release)

Summary

Solid PR overall. The QEMU + per-Python-version split is the right approach for slow emulated riscv64 builds, action versions are SHA-pinned (including the explicit tonistiigi/binfmt:qemu-v8.1.5 workaround for the documented binfmt issues), and the rewritten CIBW_ARCHS_LINUX expression (arm && 'aarch64') || matrix.qemu || 'auto' correctly resolves for all three branches. The artifact name now includes qemu/pyver, so 12 new riscv64 rows produce distinct artifacts. build_wheels is gated on a successful release, so the extra ~30min × 12 QEMU runs only land on release runs, not every PR.

The one real concern is cp314t-riscv64 — free-threaded Python under QEMU on a recently-supported architecture is fragile and could break a release if cibuildwheel can't find a working image. Recommend confirming that lane works before merging, or omitting cp314t initially. The other two items are purely cosmetic (trailing dashes/spaces in artifact and job names).

Note: this PR can't validate itself — build_wheels only runs post-release, so the first riscv64 build will happen on the next release after merge. Worth keeping an eye on that release run.

Automated review by Kōan82ad3bf
249443b

eshattow · 2026-05-17T18:26:58Z

rebased on the CI fix and force pushed

bdraco · 2026-05-17T18:33:58Z

@bluetoothbot review

bdraco · 2026-05-17T18:46:43Z

wheels work on zeroconf, already proven. no need to gate 3.14t

eshattow mentioned this pull request Apr 29, 2026

Build for RISC-V #619

Closed

bdraco approved these changes Apr 29, 2026

View reviewed changes

bdraco requested a review from Copilot April 29, 2026 11:48

Copilot started reviewing on behalf of bdraco April 29, 2026 11:49 View session

bdraco had a problem deploying to release April 29, 2026 11:51 — with GitHub Actions Failure

Copilot AI reviewed Apr 29, 2026

View reviewed changes

Comment thread .github/workflows/ci.yml Outdated

Comment thread .github/workflows/ci.yml

dlech linked an issue Apr 29, 2026 that may be closed by this pull request

Build for RISC-V #619

Closed

gounthar mentioned this pull request May 2, 2026

Epic: upstream riscv64 wheel support to all 33 packages gounthar/riscv64-python-wheels#15

Open

38 tasks

eshattow force-pushed the riscv64 branch from 254000e to facfe98 Compare May 2, 2026 23:40

eshattow temporarily deployed to release May 2, 2026 23:43 — with GitHub Actions Inactive

eshattow temporarily deployed to release May 7, 2026 09:06 — with GitHub Actions Inactive

eshattow force-pushed the riscv64 branch from 1936ca6 to 47d6e78 Compare May 7, 2026 09:14

eshattow temporarily deployed to release May 7, 2026 09:16 — with GitHub Actions Inactive

eshattow force-pushed the riscv64 branch 2 times, most recently from 0ed8364 to c2f74e9 Compare May 7, 2026 14:28

bdraco approved these changes May 17, 2026

View reviewed changes

bdraco had a problem deploying to release May 17, 2026 16:59 — with GitHub Actions Failure

bdraco mentioned this pull request May 17, 2026

fix(ci): drop -- separator in release-job git switch #668

Merged

eshattow force-pushed the riscv64 branch from f9fb117 to 1f16b6c Compare May 17, 2026 18:22

eshattow had a problem deploying to release May 17, 2026 18:23 — with GitHub Actions Failure

feat: introduce riscv64 to linux and musllinux builds

82ad3bf

bdraco had a problem deploying to release May 17, 2026 18:26 — with GitHub Actions Error

eshattow force-pushed the riscv64 branch from 5bb570a to 82ad3bf Compare May 17, 2026 18:26

eshattow temporarily deployed to release May 17, 2026 18:27 — with GitHub Actions Inactive

ci: switch riscv64 wheels to qemu emulation on ubuntu-latest

249443b

bdraco temporarily deployed to release May 17, 2026 18:31 — with GitHub Actions Inactive

bdraco merged commit 8e112c1 into Bluetooth-Devices:main May 17, 2026
23 of 24 checks passed

eshattow deleted the riscv64 branch May 17, 2026 18:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat: introduce riscv64 to linux and musllinux builds#620

feat: introduce riscv64 to linux and musllinux builds#620
bdraco merged 2 commits into
Bluetooth-Devices:mainfrom
eshattow:riscv64

eshattow commented Apr 29, 2026

Uh oh!

codecov Bot commented Apr 29, 2026 •

edited

Loading

Uh oh!

codspeed-hq Bot commented Apr 29, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

bdraco commented May 17, 2026

Uh oh!

bluetoothbot commented May 17, 2026 •

edited

Loading

Uh oh!

eshattow commented May 17, 2026

Uh oh!

bdraco commented May 17, 2026

Uh oh!

bdraco commented May 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

eshattow commented Apr 29, 2026

Uh oh!

codecov Bot commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

codspeed-hq Bot commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

bdraco commented May 17, 2026

Uh oh!

bluetoothbot commented May 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Review — feat: introduce riscv64 to linux and musllinux builds

🟡 Important

🟢 Suggestions

Checklist

Summary

Uh oh!

eshattow commented May 17, 2026

Uh oh!

bdraco commented May 17, 2026

Uh oh!

bdraco commented May 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov Bot commented Apr 29, 2026 •

edited

Loading

codspeed-hq Bot commented Apr 29, 2026 •

edited

Loading

bluetoothbot commented May 17, 2026 •

edited

Loading