src/features/admin/pages/AdminCategoriesPage.jsx (1)

771-782: ⚖️ Poor tradeoff

Las estadísticas de Visible/Oculta solo reflejan la página actual.

El "Total de Categorías" muestra el conteo global (pagination.categoryTotal), pero "Categorías Visibles" y "Categorías Ocultas" calculan sobre el array categories de la página actual. Esto puede ser confuso cuando hay múltiples páginas.

Además, si se aplica un filtro de visibilidad, los conteos serán aún menos representativos.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/features/admin/pages/AdminCategoriesPage.jsx` around lines 771 - 782, Las
métricas "Categorías Visibles" y "Categorías Ocultas" se están calculando sobre
el array de la página actual (`categories`) y no representan el total global ni
respetan filtros; cambia la fuente de verdad para esos contadores: usa los
totales globales proporcionados por el paginador/response (por ejemplo
`pagination.visibleCategoryTotal` / `pagination.hiddenCategoryTotal` o nombres
análogos) en lugar de `categories.filter(c => c.visible).length` y
`hiddenCategoriesCount`, o si el backend no expone esos campos, solicita al
backend que devuelva totales por visibilidad y usa esos valores;
alternativamente, si quieres mantener conteos por página deja claro en las
etiquetas (ej. "Visibles en esta página") y actualiza la UI para respetar
filtros usando los totales de `pagination`.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

src/features/admin/components/CategoryEditModal.jsx (1)

48-53: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Evitar cierre del modal mientras isSubmitting está activo.

Ahora se puede cerrar por overlay, Escape o botón X durante "Guardando...", dejando la operación en curso sin feedback en pantalla. Condicioná esos cierres con !isSubmitting igual que el botón Cancelar.

🔧 Ajuste propuesto

-        <div
+        <div
             role="button"
             tabIndex={0}
-            onClick={onCancel}
-            onKeyDown={e => e.key === "Escape" && onCancel()}
+            onClick={isSubmitting ? undefined : onCancel}
+            onKeyDown={e => !isSubmitting && e.key === "Escape" && onCancel()}
             style={{
@@
                     <button
                         type="button"
-                        onClick={onCancel}
+                        onClick={isSubmitting ? undefined : onCancel}
+                        disabled={isSubmitting}
                         style={{ background: "none", border: "none", cursor: "pointer", color: "`#6b7280`" }}
                     >

Also applies to: 71-77

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/features/admin/components/CategoryEditModal.jsx` around lines 48 - 53,
Evita que el modal se cierre mientras isSubmitting es true: updatea las llamadas
a onCancel en el overlay div (role="button" con onClick/onKeyDown) y en el botón
de cierre (los handlers alrededor de la sección equivalente a 71-77) para que
sólo invoquen onCancel cuando !isSubmitting; es decir, envuelve las invocaciones
actuales (onClick, onKeyDown where e.key === "Escape", y el handler del botón X)
con una comprobación if (!isSubmitting) onCancel() o condicionales inline, igual
que el botón Cancelar ya hace, para bloquear cierres durante la operación de
guardado.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

src/features/admin/pages/AdminCategoryDetailPage.jsx (1)

188-196: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Evitá renderizar Gs. NaN cuando falta originalPrice.

En Line 188-196, con p.isOffer === true y p.originalPrice inválido/ausente, la UI muestra NaN.

💵 Condición segura sugerida

-                            {p.isOffer && (
+                            {p.isOffer && Number.isFinite(Number(p.originalPrice)) && (
                                 <p style={{
                                     margin: 0,
                                     fontSize: "11px",
                                     color: "`#9ca3af`",
                                     textDecoration: "line-through"
                                 }}>
                                     Gs. {Number(p.originalPrice).toLocaleString("es-PY")}
                                 </p>
                             )}

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/features/admin/pages/AdminCategoryDetailPage.jsx` around lines 188 - 196,
When rendering the crossed original price in AdminCategoryDetailPage.jsx (inside
the product render where p.isOffer is checked), avoid displaying "Gs. NaN" by
only rendering the price when p.originalPrice is a valid number: check
Number.isFinite(Number(p.originalPrice)) (or
!isNaN(parseFloat(p.originalPrice))) before formatting with toLocaleString; if
invalid/absent, skip the whole <p> block. Update the conditional that currently
uses p.isOffer to require both p.isOffer and a numeric originalPrice (reference
the p.isOffer check and p.originalPrice field in the product render).

src/features/admin/components/CategoryEditModal.jsx (1)

70-75: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Bloqueá todos los cierres del modal mientras se está guardando.

En Line 74, Line 75, Line 108 y Line 210 todavía se puede cerrar el modal durante isSubmitting (Escape/overlay/X). Eso permite “perder” el estado visible de guardado en vuelo.

🔧 Ajuste mínimo sugerido

-    const handleOverlayClick = (event) => {
-        if (event.target === event.currentTarget) {
+    const handleOverlayClick = (event) => {
+        if (!isSubmitting && event.target === event.currentTarget) {
             onCancel();
         }
     };
@@
-        <dialog
+        <dialog
             open
             aria-modal="true"
             aria-labelledby="edit-modal-title"
-            onClose={onCancel}
+            onClose={() => {
+                if (!isSubmitting) onCancel();
+            }}
             onClick={handleOverlayClick}
@@
-                    <button
+                    <button
                         type="button"
-                        onClick={onCancel}
+                        onClick={onCancel}
+                        disabled={isSubmitting}
                         style={{ background: "none", border: "none", cursor: "pointer", color: "`#6b7280`" }}
                     >
@@
-                    <button
+                    <button
                         type="button"
-                        onClick={onCancel}
+                        onClick={onCancel}
                         disabled={isSubmitting}

Also applies to: 91-92, 106-109, 210-211

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/features/admin/components/CategoryEditModal.jsx` around lines 70 - 75,
The modal currently allows closing during in-flight saves; update the close
handlers to block closes when isSubmitting is true: add an early-return guard so
onCancel ignores attempts to close while isSubmitting, update handleOverlayClick
to not call onCancel (or to return) when isSubmitting, and apply the same guard
to the close-button click/handler and any Escape/onClose invocation paths used
in CategoryEditModal.jsx; reference the isSubmitting flag in each handler
(onCancel, handleOverlayClick and the close-button onClick/Escape handler) so
attempts to close are no-ops until isSubmitting is false.

src/features/admin/pages/AdminCategoriesPage.jsx (1)

33-36: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Agregá semántica modal explícita en el dialog.

En Line 33-36 falta aria-modal="true", y eso degrada la accesibilidad del overlay como diálogo modal real.

♿ Fix mínimo

         <dialog
             open
+            aria-modal="true"
             aria-labelledby={labelId}

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/features/admin/pages/AdminCategoriesPage.jsx` around lines 33 - 36, Add
the explicit modal semantics to the dialog element by adding aria-modal="true"
to the <dialog> tag that currently has open and aria-labelledby={labelId};
update the JSX for the dialog component (the element using aria-labelledby and
labelId in AdminCategoriesPage) to include aria-modal="true" so assistive tech
treats this overlay as a true modal dialog.

src/features/admin/components/CategoryEditModal.jsx (1)

65-67: ⚡ Quick win

stopPropagation acá es redundante y se puede eliminar.

En Line 60 ya filtrás cierre por event.target === event.currentTarget, así que el onClick del contenedor interno (Line 91) no aporta comportamiento.

🧹 Simplificación sugerida

-    const stopPropagation = (event) => {
-        event.stopPropagation();
-    };
@@
-            <div
-                onClick={stopPropagation}
-                style={{
+            <div
+                style={{

Also applies to: 90-92

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/features/admin/components/CategoryEditModal.jsx` around lines 65 - 67,
Remove the redundant stopPropagation helper and any onClick={stopPropagation}
usages inside the modal: the outer click handler already checks event.target ===
event.currentTarget to detect backdrop clicks, so the inner container's onClick
(and the stopPropagation function declaration) can be deleted; search for the
stopPropagation function and any inner container onClick attributes in
CategoryEditModal.jsx and remove them to simplify the modal click handling.