Remove git checks in SBOM payload generation#1487
Merged
Merged
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 152 Passed, 0 Skipped, 1m 13.86s Total duration (2m 16.3s time saved) |
5456445 to
820afe8
Compare
added 5 commits
November 12, 2024 15:41
The checks that were removed are now being done earlier as part of #1489
820afe8 to
e21c8c0
Compare
dastrong
reviewed
Nov 12, 2024
| { | ||
| "name": "@datadog/datadog-ci", | ||
| "version": "2.45.0", | ||
| "version": "2.46.0", |
Contributor
There was a problem hiding this comment.
This won't be a breaking change, so we might want to bump the patch version only?
Contributor
There was a problem hiding this comment.
@tanishq-dubey can you undo this change in your PR? Bumping the version in package.json is part of the release process and should be done in its own PR 🙇
Contributor
Author
There was a problem hiding this comment.
@Drarig29 I can remove the version bump from this PR and create a new one for the release.
Drarig29
reviewed
Nov 13, 2024
Drarig29
approved these changes
Nov 13, 2024
vitor-de-araujo
approved these changes
Nov 15, 2024
402b287 to
f063dd5
Compare
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why?
STAL-3069If all required git tags are not in our analysis, we returned a generic failure message on payload upload. This made debugging difficult for users. We are now returning the specific git tags that are missing to make debugging easier.How?
This change adds a new error message renderer for missing git fields, and changes the tag requirement logic to share it between the error renderer and thegeneratePayloadcheckMust of this ticket was completed in #1489, this PR finishes up the error handling in the payload.
Review checklist