Skip to content

[SYNTH-17698] Fix local test definition variable case#1515

Merged
AntoineDona merged 1 commit into
masterfrom
antoine.donascimento/fix-ltd-variable
Jan 2, 2025
Merged

[SYNTH-17698] Fix local test definition variable case#1515
AntoineDona merged 1 commit into
masterfrom
antoine.donascimento/fix-ltd-variable

Conversation

@AntoineDona

Copy link
Copy Markdown
Contributor

What and why?

Fixes the case of the variable containing the local test definition. Before it was in Camel Case but it should have been in snake case.

Note: There are still some instances of the Camel Case version, but it is only for variables defined in typescript as it is required by the linter.

How?

  • Change localTestDefinition to local_test_definition

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)

@AntoineDona AntoineDona requested review from a team as code owners January 2, 2025 14:28
@datadog-datadog-prod-us1

Copy link
Copy Markdown

Datadog Report

Branch report: antoine.donascimento/fix-ltd-variable
Commit report: 22ce656
Test service: datadog-ci-tests

✅ 0 Failed, 6008 Passed, 0 Skipped, 3m 13.41s Total duration (35.42s time saved)

@AntoineDona AntoineDona added the synthetics Related to [synthetics] label Jan 2, 2025

@Alexis-Jacob-datadog Alexis-Jacob-datadog left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

synthetics Related to [synthetics]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants