Skip to content

[react] Add types for experimental_use#62189

Merged
johnnyreilly merged 1 commit into
DefinitelyTyped:masterfrom
eps1lon:feat/react/use-hook
Sep 10, 2022
Merged

[react] Add types for experimental_use#62189
johnnyreilly merged 1 commit into
DefinitelyTyped:masterfrom
eps1lon:feat/react/use-hook

Conversation

@eps1lon

@eps1lon eps1lon commented Sep 10, 2022

Copy link
Copy Markdown
Collaborator

Please fill in this template.

If changing an existing definition:

@eps1lon eps1lon force-pushed the feat/react/use-hook branch from f625611 to 7957a73 Compare September 10, 2022 08:54
@DangerBotOSS

Copy link
Copy Markdown

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

react (unpkg)

was missing the following properties:

  1. unstable_act

Generated by 🚫 dangerJS against 7957a73

@eps1lon eps1lon marked this pull request as ready for review September 10, 2022 09:18
@typescript-bot

typescript-bot commented Sep 10, 2022

Copy link
Copy Markdown
Contributor

@eps1lon Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Most recent commit is approved by a DT maintainer

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 62189,
  "author": "eps1lon",
  "headCommitOid": "7957a730aabafe107ce3219af899abd2b52ec2ee",
  "mergeBaseOid": "55c08b65328e644db2b5a74c91e02dde6d42c2c2",
  "lastPushDate": "2022-09-10T08:53:59.000Z",
  "lastActivityDate": "2022-09-10T09:18:56.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "react",
      "kind": "edit",
      "files": [
        {
          "path": "types/react/experimental.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react/test/experimental.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "johnnyreilly",
        "bbenezech",
        "pzavolinsky",
        "ericanderson",
        "DovydasNavickas",
        "theruther4d",
        "guilhermehubner",
        "ferdaber",
        "jrakotoharisoa",
        "pascaloliv",
        "hotell",
        "franklixuefei",
        "Jessidhia",
        "saranshkataria",
        "lukyth",
        "eps1lon",
        "zieka",
        "dancerphil",
        "dimitropoulos",
        "disjukr",
        "vhfmag",
        "hellatan",
        "priyanshurav"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 1242679087,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Critical package Author is Owner The author of this PR is a listed owner of the package. labels Sep 10, 2022
@typescript-bot

Copy link
Copy Markdown
Contributor

🔔 @johnnyreilly @bbenezech @pzavolinsky @ericanderson @DovydasNavickas @theruther4d @guilhermehubner @ferdaber @jrakotoharisoa @pascaloliv @Hotell @franklixuefei @Jessidhia @saranshkataria @lukyth @zieka @dancerphil @dimitropoulos @disjukr @vhfmag @hellatan @priyanshurav — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@johnnyreilly johnnyreilly merged commit 72c1299 into DefinitelyTyped:master Sep 10, 2022
@johnnyreilly

Copy link
Copy Markdown
Member

Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Author is Owner The author of this PR is a listed owner of the package. Critical package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants