[rr-notifications] Test intended usage#65136
Conversation
|
@eps1lon Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and there were no type definition changes, I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 65136,
"author": "eps1lon",
"headCommitOid": "64c4031f00add240b04bb5468fb6777bd7b85220",
"mergeBaseOid": "78144d12c9a1b0fba042c9828bfab3a4a1fc5347",
"lastPushDate": "2023-04-15T09:25:20.000Z",
"lastActivityDate": "2023-04-26T16:29:36.000Z",
"mergeOfferDate": "2023-04-26T15:23:13.000Z",
"mergeRequestDate": "2023-04-26T16:29:36.000Z",
"mergeRequestUser": "eps1lon",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "rr-notifications",
"kind": "edit",
"files": [
{
"path": "types/rr-notifications/rr-notifications-tests.tsx",
"kind": "test"
},
{
"path": "types/rr-notifications/tsconfig.json",
"kind": "package-meta-ok"
}
],
"owners": [
"RobbieGM"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "RobbieGM",
"date": "2023-04-26T15:22:28.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 1509714634,
"ciResult": "pass"
} |
|
🔔 @RobbieGM — please review this PR in the next few days. Be sure to explicitly select |
|
Re-ping @RobbieGM: This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
|
@eps1lon: Everything looks good here. I am ready to merge this PR (at 64c4031) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@RobbieGM: you can do this too.) |
|
Ready to merge |
The
FunctionComponenttype is not intended to be called (because the runtime implementation might have hooks). Therefore its return value is also not meant as a public API.If you want to type a function that returns a
React.ReactElement | nullyou should type it as such.Though I'm fairly certain
NotificationsProvideris meant to be used in JSX so we now test it as such.Required for #65135