commits from bitcoin/master#343
Merged
Merged
Conversation
Files should depend on one another by interface, not by implementation. This checks for quoted includes as well. With practicalswift
The code was converting CMutableTransaction to CTransaction multiple times, which implies recalculating the hash multiple times. This commit fixes this by reusing a single CTransaction.
All the other operators are integer or bit operations, and this is unused apart from tests.
Checking for and removing any bitcoin addresses in translations
Rather than appending all possible cpu variants to all targets, create a convenience variable that encompasses all.
labels are associated with addresses (rather than addresses being associated with labels, as was the case with accounts). The getlabeladdress does not make sense in this model, so remove it. getaccountaddress is still supported for one release as the accounts API is deprecated.
FeatherCoin
approved these changes
Jun 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lint: Add linter to error on #include <*.cpp>
bitcoin/bitcoin#13301
build: Add linter checking for accidental introduction of locale dependence
bitcoin/bitcoin#13041
cli: Ignore libevent warnings
bitcoin/bitcoin#13394
[docs] update transifex doc link
bitcoin/bitcoin#13369
[tests] speed up of tx_validationcache_tests by reusing of CTransaction.
bitcoin/bitcoin#13404
Make reusable base class for auxiliary indices
bitcoin/bitcoin#13243
Drop unused arith_uint256 ! operator
bitcoin/bitcoin#13396
refactoring: add a method for determining if a block is pruned or not
bitcoin/bitcoin#13259
utils and libraries: checking for bitcoin address in translations
bitcoin/bitcoin#13374
[qt] OptionsDialog: add prune setting
bitcoin/bitcoin#13043
qa: Remove portseed_offset from test runner
bitcoin/bitcoin#13421
crypto: cleanup sha256 build
bitcoin/bitcoin#13408
Fix compiler warnings emitted when compiling under stock OpenBSD 6.3
bitcoin/bitcoin#13294
[wallet] [rpc] Remove getlabeladdress RPC
bitcoin/bitcoin#13060
[refactor] Make TransactionWithinChainLimit more flexible
bitcoin/bitcoin#12634
Simplify include analysis by enforcing the developer guide's include syntax
bitcoin/bitcoin#13230