Download private assets with PAT#4
Merged
Merged
Conversation
ddosia
reviewed
Feb 14, 2022
| exit 1 | ||
| fi; | ||
|
|
||
| wget -q --auth-no-challenge --header='Accept:application/octet-stream' \ |
Contributor
There was a problem hiding this comment.
Is there any way to use curl instead of wget so there won't be necessary to install both of them?
ddosia
reviewed
Feb 14, 2022
| @@ -0,0 +1,34 @@ | |||
| # Install private repo asset with PAT (Personal Access Token) | |||
Contributor
There was a problem hiding this comment.
Can you update main README as well?
ddosia
approved these changes
Feb 14, 2022
ddosia
left a comment
Contributor
There was a problem hiding this comment.
Overall +1.
But in particular I have a concern related to using docker image.
The script to access GithHub API is pretty straightforward and could have been implemented on top of yaml. With using docker one brings several variables, it could be rate limited by dockerhub and also there are some delays to build the docker image itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.