Skip to content

fix: SQL Server tinyiny type detection#1784

Open
nj1973 wants to merge 2 commits into
developfrom
1585-sql-server-incorrect-results-tinyint
Open

fix: SQL Server tinyiny type detection#1784
nj1973 wants to merge 2 commits into
developfrom
1585-sql-server-incorrect-results-tinyint

Conversation

@nj1973

@nj1973 nj1973 commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Description of changes

SQL Server's tinyint is an unsigned 8-bit integer, meaning it stores values from 0 to 255. Ibis 8-bit integer is signed, meaning it stores range -128 to 127.

Change in this PR detects SQL Server tinyint as 16-bit int.

Issues to be closed

Closes #1585

Checklist

  • I have followed the CONTRIBUTING Guide.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated any relevant documentation to reflect my changes, if applicable
  • I have added unit and/or integration tests relevant to my change as needed
  • I have already checked locally that all unit tests and linting are passing (use the tests/local_check.sh script)
  • I have manually executed end-to-end testing (E2E) with the affected databases/engines

@nj1973

nj1973 commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator Author

/gcbrun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SQL Server incorrect results for column validation max of tinyint value

1 participant