Replace linear scan in BuilderIndexByPubkey with O(1) map#16813
Merged
Conversation
df0fd1e to
8ba2f8e
Compare
potuz
approved these changes
May 20, 2026
potuz
left a comment
Contributor
There was a problem hiding this comment.
LGTM, would be good to have some extra eyes regarding the full copy path. I did my best effort to trace that the map is correctly initialized on every path that reads a state either from memory or DB (eg StateByRoot) and it seems fine.
satushh
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BuilderIndexByPubkeywith an O(1) pubkey→index map onBeaconState. Per-state, deep-copied onCopy()