Only add proposer boost to same shufflings as head#16846
Merged
Conversation
When an incoming block arrives, only add proposer boost to it if the proposer is the same as the expected one from the current head's shuffling perspective. Head is cached before insertion and we do not use the shuffling that would be expected after counting the attestations in the block for example.
| s.proposerBoostRoot = root | ||
| depEpoch := slots.ToEpoch(currentSlot) | ||
| if depEpoch > 1 { | ||
| depEpoch -= 2 |
Collaborator
There was a problem hiding this comment.
block epoch is 100, wouldnt you get epoch 97's root but you want epoch 98's root right?
james-prysm
approved these changes
May 29, 2026
terencechain
approved these changes
May 29, 2026
Contributor
|
ship it |
james-prysm
pushed a commit
that referenced
this pull request
Jun 8, 2026
When an incoming block arrives, only add proposer boost to it if the proposer is the same as the expected one from the current head's shuffling perspective. Head is cached before insertion and we do not use the shuffling that would be expected after counting the attestations in the block for example,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an incoming block arrives, only add proposer boost to it if the proposer is the same as the expected one from the current head's shuffling perspective. Head is cached before insertion and we do not use the shuffling that would be expected after counting the attestations in the block for example,