Remove Math.min64 and Math.max64#1156
Merged
Merged
Conversation
nventuro
reviewed
Aug 6, 2018
nventuro
left a comment
Contributor
There was a problem hiding this comment.
Woohoo deprecation!
This is not strictly related to this PR, but the min and max tests are not what you'd call comprehensive (there's only one test for each ffs), shouldn't we address this?
| contract MathMock { | ||
| uint64 public result64; | ||
| uint256 public result256; | ||
| uint256 public result; |
Contributor
There was a problem hiding this comment.
Is there a need for this? I'd remove it altogether and have the functions return the result (like SafeMathMock does).
Contributor
Author
|
@nventuro Please review again. 🙂 |
nventuro
approved these changes
Aug 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These two functions were added at a point where we used
uint64values in a contract, but we have since made everythinguint256and this is what we recommend so we should remove the 64-bit variants.