Roles now emit events in construction and when renouncing.#1329
Merged
Conversation
2210d5b to
5012443
Compare
frangio
reviewed
Sep 17, 2018
frangio
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Can we add tests for the constructor events? We can use the hash of the creation transaction that is included in the contract instance. Not sure if there is an easier way.
(cherry picked from commit c12a1c6)
5012443 to
b51236e
Compare
frangio
approved these changes
Sep 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think using the
Removedevent is fine forrenounce, but I'm open to discussion. Also, I'm not sure if there's an easy way of testing for events in a contract creation.