Skip to content

Fix #1358 Test helper to send funds#1367

Merged
nventuro merged 13 commits into
OpenZeppelin:masterfrom
Aniket-Engg:fix-#1358
Oct 1, 2018
Merged

Fix #1358 Test helper to send funds#1367
nventuro merged 13 commits into
OpenZeppelin:masterfrom
Aniket-Engg:fix-#1358

Conversation

@Aniket-Engg

@Aniket-Engg Aniket-Engg commented Oct 1, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #1358

🚀 Description

Test helper for sending funds has been added and tested in BreakInvariantBounty.test.js

  • 📘 I've reviewed the OpenZeppelin Contributor Guidelines
  • ✅ I've added tests where applicable to test my new functionality.
  • 📖 I've made sure that my contracts are well-documented.
  • 🎨 I've run the JS/Solidity linters and fixed any issues (npm run lint:fix).

@nventuro nventuro self-assigned this Oct 1, 2018
@nventuro nventuro added feature New contracts, functions, or helpers. tests Test suite and helpers. labels Oct 1, 2018
nventuro
nventuro reviewed Oct 1, 2018
View reviewed changes

@nventuro nventuro left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Aniket-Engg, thanks a lot for taking care of this! Left a couple review comments.

Also, could you remove the .eslintrc and package-lock.json changes from the PR? Thanks!

Comment thread test/helpers/sendTransaction.js
Comment thread test/BreakInvariantBounty.test.js
nventuro
nventuro approved these changes Oct 1, 2018
View reviewed changes

@nventuro nventuro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo, thanks for the quick response @Aniket-Engg!

@nventuro nventuro merged commit fa1dfbd into OpenZeppelin:master Oct 1, 2018
@Aniket-Engg

Aniket-Engg commented Oct 1, 2018

Copy link
Copy Markdown
Contributor Author

Thank you so much ! @nventuro

come-maiz pushed a commit that referenced this pull request Oct 21, 2018
@Aniket-Engg
Fix #1358 Test helper to send funds (#1367)
c25a1e3 
* signing prefix added

* Minor improvement

* Tests changed

* Successfully tested

* Minor improvements

* Minor improvements

* Revert "Dangling commas are now required. (#1359)"

This reverts commit a688977.

* fixes #1358

* linting done

* suggested changes

(cherry picked from commit fa1dfbd)
@Aniket-Engg Aniket-Engg deleted the fix-#1358 branch December 10, 2018 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@nventuro nventuro nventuro approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@nventuro nventuro

Labels

feature New contracts, functions, or helpers. tests Test suite and helpers.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add test helper to send funds

2 participants

@Aniket-Engg @nventuro