Skip to content

Prevents Bounty from being claimed twice#1374

Merged
nventuro merged 16 commits into
OpenZeppelin:masterfrom
Aniket-Engg:fix/#1356
Oct 3, 2018
Merged

Prevents Bounty from being claimed twice#1374
nventuro merged 16 commits into
OpenZeppelin:masterfrom
Aniket-Engg:fix/#1356

Conversation

@Aniket-Engg

@Aniket-Engg Aniket-Engg commented Oct 3, 2018

Copy link
Copy Markdown
Contributor

Fixes #1356

🚀 Description

Now it prevent reclaim of bounty once distributed. It is related to this comment.

  • 📘 I've reviewed the OpenZeppelin Contributor Guidelines
  • ✅ I've added tests where applicable to test my new functionality.
  • 📖 I've made sure that my contracts are well-documented.
  • 🎨 I've run the JS/Solidity linters and fixed any issues (npm run lint:fix).

@nventuro nventuro added contracts Smart contract code. breaking change Changes that break backwards compatibility of the public API. labels Oct 3, 2018
@nventuro nventuro self-assigned this Oct 3, 2018
@nventuro nventuro self-requested a review October 3, 2018 15:38
nventuro
nventuro approved these changes Oct 3, 2018
View reviewed changes

@nventuro nventuro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love these small PRs @Aniket-Engg, keep them coming! 😁

@nventuro nventuro merged commit c87433e into OpenZeppelin:master Oct 3, 2018
@Aniket-Engg Aniket-Engg deleted the fix/#1356 branch October 3, 2018 17:09
@Aniket-Engg

Aniket-Engg commented Oct 3, 2018

Copy link
Copy Markdown
Contributor Author

sure @nventuro

nventuro pushed a commit that referenced this pull request Oct 4, 2018
@Aniket-Engg @nventuro
Prevents Bounty from being claimed twice (#1374)
7c98496 
* signing prefix added

* Minor improvement

* Tests changed

* Successfully tested

* Minor improvements

* Minor improvements

* Revert "Dangling commas are now required. (#1359)"

This reverts commit a688977.

* updates

* fixes #1356

* Removed extra semicolon.

(cherry picked from commit c87433e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@nventuro nventuro nventuro approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@nventuro nventuro

Labels

breaking change Changes that break backwards compatibility of the public API. contracts Smart contract code.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Prevent Bounty from being claimed twice.

2 participants

@Aniket-Engg @nventuro