Removed selfdestruct from BreakInvariantBounty#1385
Conversation
This reverts commit a688977.
|
Hi @Aniket-Engg, thanks for promptly tackling this! However, we should just remove the function - we should have a function with the same functionality: transferring all balance to the owner, and not letting the bounty continue to be used. |
Should it be something like this? @nventuro |
|
That's a good starting point. A couple ideas:
Let me know what you think! |
|
what are your thoughts behind choosing |
|
Currently, a bounty may be not claimed, claimed, or destroyed. A cancelled bounty is obviously not claimed, so we need a better word. I suggested 'ongoing', but 'claimable' may be better (a canceled bounty is not claimable). |
|
|
|
@nventuro Please check the changes and let me know your views. I will add tests for |
nventuro
left a comment
There was a problem hiding this comment.
Looks great @Aniket-Engg! I only have two minor suggestions, feel free to add tests so we can merge this :)
nventuro
left a comment
There was a problem hiding this comment.
Thanks a lot for this @Aniket-Engg, love how fast you're closing issues! 🙌
|
I am also loving being a part of it. Thanks for your appreciation. 😊 |
* signing prefix added * Minor improvement * Tests changed * Successfully tested * Minor improvements * Minor improvements * Revert "Dangling commas are now required. (OpenZeppelin#1359)" This reverts commit a688977. * updates * fixes OpenZeppelin#1384 * introduced claimable and cancelBounty * cancelBounty tests * Update BreakInvariantBounty.test.js (cherry picked from commit 41f84f8)
Fixes #1384
Removed
selfdestructfrom BreakInvariantBounty and related test cases