Improves Ownable events#1397
Merged
Merged
Conversation
This reverts commit a688977.
Contributor
|
Thanks a lot @Aniket-Engg! Looks like the |
Contributor
Author
|
okay @nventuro . I also saw that issue and was not sure for constructor event. |
nventuro
reviewed
Oct 8, 2018
nventuro
approved these changes
Oct 9, 2018
nventuro
left a comment
Contributor
There was a problem hiding this comment.
Another great PR @Aniket-Engg, thanks a lot!
nventuro
pushed a commit
to nventuro/openzeppelin-contracts
that referenced
this pull request
Oct 18, 2018
* signing prefix added * Minor improvement * Tests changed * Successfully tested * Minor improvements * Minor improvements * Revert "Dangling commas are now required. (OpenZeppelin#1359)" This reverts commit a688977. * updates * fixes OpenZeppelin#1392 * event tests added * constructor event added (cherry picked from commit af42c39)
come-maiz
pushed a commit
that referenced
this pull request
Oct 21, 2018
* signing prefix added * Minor improvement * Tests changed * Successfully tested * Minor improvements * Minor improvements * Revert "Dangling commas are now required. (#1359)" This reverts commit a688977. * updates * fixes #1392 * event tests added * constructor event added (cherry picked from commit af42c39)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1392