Skip to content

Non-constructor initialization removed#1403

Merged
nventuro merged 21 commits into
OpenZeppelin:masterfrom
Aniket-Engg:fix/#1391
Oct 10, 2018
Merged

Non-constructor initialization removed#1403
nventuro merged 21 commits into
OpenZeppelin:masterfrom
Aniket-Engg:fix/#1391

Conversation

@Aniket-Engg

Copy link
Copy Markdown
Contributor

Fixes #1391

@Aniket-Engg

Aniket-Engg commented Oct 10, 2018

Copy link
Copy Markdown
Contributor Author

I have gone through each contract file to ensure this. In case, any file is missing to update, let me know.

@nventuro nventuro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work as always @Aniket-Engg, thanks!

@nventuro nventuro merged commit da67e43 into OpenZeppelin:master Oct 10, 2018
@Aniket-Engg Aniket-Engg deleted the fix/#1391 branch October 10, 2018 12:34
@Aniket-Engg

Copy link
Copy Markdown
Contributor Author

😊

come-maiz pushed a commit that referenced this pull request Oct 21, 2018
* signing prefix added

* Minor improvement

* Tests changed

* Successfully tested

* Minor improvements

* Minor improvements

* Revert "Dangling commas are now required. (#1359)"

This reverts commit a688977.

* updates

* fixes #1391

(cherry picked from commit da67e43)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants