Skip to content

Reorganize the repo structure#2503

Merged
frangio merged 41 commits into
OpenZeppelin:masterfrom
Amxx:refactor/reporeorg
Feb 22, 2021
Merged

Reorganize the repo structure#2503
frangio merged 41 commits into
OpenZeppelin:masterfrom
Amxx:refactor/reporeorg

Conversation

@Amxx

@Amxx Amxx commented Feb 2, 2021 •
edited by frangio
Loading

Copy link
Copy Markdown
Collaborator

Fixes #2527. See the issue for more details.

PR Checklist

  • Tests
  • Documentation
  • Changelog entry

@frangio

frangio commented Feb 8, 2021

Copy link
Copy Markdown
Contributor

Notes from offline conversation:

  • Interfaces such as a IERC777Sender should go at the top level ERC777 directory.
  • Rename proxy/upgradeable to proxy/transparent and move UpgradeableProxy to proxy.
  • Maybe TimelockController should go in its own directory of standalone contracts. Does this belong in utils? This category could also contain TokenTimelock, PaymentSplitter.
  • A new enumerable directory.
  • Try to move mocks directory somewhere less visible.

@Amxx

Amxx commented Feb 12, 2021

Copy link
Copy Markdown
Collaborator Author

What about moving the mocks/* into test/mocks/* ?

@Amxx Amxx force-pushed the refactor/reporeorg branch from 0e3f452 to ea9a0c6 Compare February 15, 2021 15:53
@frangio frangio changed the title Reorganize the repo's structure. Reorganize the repo structure Feb 17, 2021
@Amxx Amxx marked this pull request as ready for review February 17, 2021 17:56
@Amxx Amxx force-pushed the refactor/reporeorg branch from 92c2802 to 5bd4344 Compare February 18, 2021 18:43
@Amxx Amxx force-pushed the refactor/reporeorg branch from 76f6aae to 7b6c6b2 Compare February 18, 2021 19:40
frangio
frangio previously approved these changes Feb 19, 2021
View reviewed changes
@frangio frangio added the on hold Put on hold for some reason that must be specified in a comment. label Feb 19, 2021
@frangio

frangio commented Feb 19, 2021

Copy link
Copy Markdown
Contributor

Will merge on Monday!

@frangio frangio removed the on hold Put on hold for some reason that must be specified in a comment. label Feb 22, 2021
@frangio frangio enabled auto-merge (squash) February 22, 2021 16:39
@frangio frangio merged commit 24a0bc2 into OpenZeppelin:master Feb 22, 2021
@frangio frangio mentioned this pull request Feb 22, 2021
Closed
@Amxx Amxx deleted the refactor/reporeorg branch February 22, 2021 23:18
codewiz added a commit to codewiz/avalanche-docs that referenced this pull request Feb 26, 2021
@codewiz
Update the url of ERC20PresetMinterPauser.sol
d7c25d1 
It was moved in this PR: OpenZeppelin/openzeppelin-contracts#2503
@codewiz codewiz mentioned this pull request Feb 26, 2021
Merged
jpop32 pushed a commit to ava-labs/builders-hub that referenced this pull request Mar 4, 2021
@codewiz @jpop32
Update the url of ERC20PresetMinterPauser.sol
be01bba 
It was moved in this PR: OpenZeppelin/openzeppelin-contracts#2503
@dependabot dependabot Bot mentioned this pull request Mar 15, 2021
Closed
@ghidello ghidello mentioned this pull request Mar 21, 2021
Merged
@OpenZeppelin OpenZeppelin deleted a comment from Rsed19901 Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frangio frangio frangio approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Reorganize contracts for better discoverability and clarity

2 participants

@Amxx @frangio