Skip to content

Rename UpgradeableProxy to ERC1967Proxy#2547

Merged
frangio merged 8 commits into
OpenZeppelin:masterfrom
Amxx:refactor/ERC1967
Mar 2, 2021
Merged

Rename UpgradeableProxy to ERC1967Proxy#2547
frangio merged 8 commits into
OpenZeppelin:masterfrom
Amxx:refactor/ERC1967

Conversation

@Amxx

@Amxx Amxx commented Mar 1, 2021

Copy link
Copy Markdown
Collaborator

In preparation for the evolution of proxy, and the possible addition of UUPS like proxy mechanisms:

  • mv/rename proxy/UpgradeableProxy.solproxy/ERC1967/ERC1967Proxy.sol
  • refactor of proxy tests

PR Checklist

  • Tests
  • Documentation
  • Changelog entry

@frangio

frangio commented Mar 1, 2021

Copy link
Copy Markdown
Contributor

For documentation, update proxy/README.adoc to refer to the new contract name, and see if any part of the text needs to be updated.

Please change the PR title to describe the change.

The rest looks good!

@Amxx Amxx changed the title Refactor/erc1967 Rename UpgradeableProxy to ERC1967Proxy Mar 1, 2021
frangio
frangio previously approved these changes Mar 1, 2021

@frangio frangio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

Comment thread contracts/proxy/README.adoc Outdated
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
@frangio frangio merged commit c789941 into OpenZeppelin:master Mar 2, 2021
@Amxx Amxx deleted the refactor/ERC1967 branch March 2, 2021 14:23
Amxx added a commit that referenced this pull request Mar 2, 2021
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
Amxx added a commit that referenced this pull request Mar 2, 2021
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
(cherry picked from commit c789941)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants