Add interface for ERC6909#5343
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 96bb50a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Amxx
reviewed
Dec 6, 2024
Amxx
reviewed
Dec 11, 2024
ernestognw
reviewed
Dec 11, 2024
Co-authored-by: Ernesto García <ernestognw@gmail.com>
Member
Author
|
There are 3 extensions to the base ERC6909 defined in the ERC. Should we add interfaces for all of them? They are ContractURI, Metadata, and TokenSupply. |
Collaborator
|
Yes, I would have all 3 extensions declared in the same file. |
ernestognw
reviewed
Dec 18, 2024
ernestognw
reviewed
Dec 18, 2024
ernestognw
previously approved these changes
Dec 18, 2024
ernestognw
left a comment
Member
There was a problem hiding this comment.
Updated title since we're not implementing the interface.
Amxx
reviewed
Dec 18, 2024
Amxx
reviewed
Dec 18, 2024
Amxx
reviewed
Dec 18, 2024
Amxx
reviewed
Dec 18, 2024
Amxx
reviewed
Dec 18, 2024
Amxx
approved these changes
Dec 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the
ERC6909interface to the repo.PR Checklist
npx changeset add)