[P2P] Remove p2p alert system#1372
Merged
random-zebra merged 7 commits intoMar 13, 2020
Merged
Conversation
900ece9 to
d1368d4
Compare
Backports bitcoin/bitcoin@01fdfef Also remove alert command
Backports bitcoin/bitcoin@1b77471
d1368d4 to
ce8ff4b
Compare
Author
|
Rebased. |
Fuzzbawls
approved these changes
Mar 6, 2020
furszy
reviewed
Mar 7, 2020
|
|
||
| void ClientModel::updateAlert() | ||
| { | ||
| Q_EMIT alertsChanged(getStatusBarWarnings()); |
There was a problem hiding this comment.
alertChanged signal is not connected to the GUI at all, can remove it entirely from clientModel. Including the NotifyAlertChanged boost event binding.
Author
There was a problem hiding this comment.
Wouldn't it be better to actually connect the alertsChanged signal and show the messages somewhere in the GUI (e.g. "Large-work fork detected")?
In case, we can do it in a successive PR.
Collaborator
There was a problem hiding this comment.
yes this is something we've discussed before. alert type messages need to be presented in the GUI in a future PR.
furszy
approved these changes
Mar 13, 2020
akshaynexus
added a commit
to ZENZO-Ecosystem/ZENZO-Core
that referenced
this pull request
Mar 15, 2020
ce8ff4b [Doc] Document removal of p2p alert system (random-zebra) a296c6f [Trivial] Fix NotifyAlertChanged comment (cs_mapAlerts not required) (random-zebra) 06fdc6a [Build] CMake: remove alert.cpp (random-zebra) 39c412a Remove alert keys (random-zebra) 936ca82 Remove p2p alert handling (random-zebra) d06eceb Remove `-alerts` option (random-zebra) 2ebd863 Update alert notification and GUI (random-zebra) Pull request description: This completely removes the p2p network alert messaging system. Based on upstream bitcoin#7692 Patches CVE-2016-10724 / CVE-2016-10725 ACKs for top commit: Fuzzbawls: utACK ce8ff4b furszy: utACK ce8ff4b Tree-SHA512: 40b2a023a53af880388337d52680fa100265ff704da8d51e889ca12cf97293cc0914ef3c4a57052ed342682fda08457f8f0fd8c0184d2aa408647ea6a0e5078d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This completely removes the p2p network alert messaging system.
Based on upstream bitcoin#7692
Patches CVE-2016-10724 / CVE-2016-10725