Eliminate actions/cache@v2 usage#2322
Merged
Merged
Conversation
GitHub is shutting down this old action version on February 1st, 2025. In addition, its usage here is no longer needed, because new versions of `actions/setup-python` can do this caching. https://github.blog/changelog/2024-09-16-notice-of-upcoming-deprecations-and-changes-in-github-actions-services/
DanielNoord
reviewed
Jan 9, 2025
| uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: ${{ matrix.python-version }} | ||
| cache: "pip" |
Contributor
Author
There was a problem hiding this comment.
Setting it to pip maintains parity with the previous caching usage, which was caching the packages downloaded by pip, not virtual environments created by Poetry.
Contributor
Author
There was a problem hiding this comment.
DanielNoord
approved these changes
Jan 9, 2025
DanielNoord
left a comment
Member
There was a problem hiding this comment.
Thanks, didn't notice that we were not caching poetry previously.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub is shutting down this old action version on February 1st, 2025.
In addition, its usage here is no longer needed, because new versions of
actions/setup-pythoncan do this caching.@DanielNoord As noted above, this is a time-sensitive PR because
actions/cache@v2will be removed from GitHub soon.