Skip to content

Add test_import from CPython 3.8#3018

Closed
fanninpm wants to merge 3 commits into
RustPython:mainfrom
fanninpm:test-import
Closed

Add test_import from CPython 3.8#3018
fanninpm wants to merge 3 commits into
RustPython:mainfrom
fanninpm:test-import

Conversation

@fanninpm

@fanninpm fanninpm commented Sep 6, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@fanninpm

fanninpm commented Sep 6, 2021

Copy link
Copy Markdown
Contributor Author

I can't reproduce the CI failures locally.

@DimitrisJim

DimitrisJim commented Sep 9, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Hm, I'm actually getting errors for test_os.py. Are things still passing locally for you?

@fanninpm

fanninpm commented Sep 10, 2021

Copy link
Copy Markdown
Contributor Author

Hm, I'm actually getting errors for test_os.py. Are things still passing locally for you?

I'm not getting any failures, but I am getting a few instances of OverflowError: Python int too large to convert to Rust u32. These seem to happen with test_setregid_neg1 and test_setreuid_neg1.

@DimitrisJim

DimitrisJim commented Sep 27, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Bump, I ran these again and indeed I locally cannot repro the errors (something weird was going on when I tried to run tests last time).

It looks like test_import is failing on Windows while test_unittest is failing on the others. If these failures are just one or two functions we could probably just skip for CI as we usually do.

@youknowone

youknowone commented Apr 7, 2025

Copy link
Copy Markdown
Member

test_import 3.11 is merged by #4599

@youknowone youknowone closed this Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fanninpm @DimitrisJim @youknowone