Skip to content

Make determine_changes step run on ubuntu-slim#7790

Merged
youknowone merged 1 commit into
RustPython:mainfrom
fanninpm:deterime-changes-ubuntu-slim
May 6, 2026
Merged

Make determine_changes step run on ubuntu-slim#7790
youknowone merged 1 commit into
RustPython:mainfrom
fanninpm:deterime-changes-ubuntu-slim

Conversation

@fanninpm

@fanninpm fanninpm commented May 6, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Since the ubuntu-slim image contains the git executable by default, we can use this image and thus improve our actions parallelism.

Ideally, we should consider extracting the cargo_check step into a separate GitHub Actions .yaml file, possibly obviating the need for the determine_changes step.

cc @ShaharNaveh

Summary by CodeRabbit

  • Chores
    • Optimized CI workflow configuration for improved build efficiency.

@coderabbitai

coderabbitai Bot commented May 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 9b70f88e-f591-479c-95fe-ccedb7d739a5

📥 Commits

Reviewing files that changed from the base of the PR and between 22d4f43 and 50f5f56.

📒 Files selected for processing (1)
  • .github/workflows/ci.yaml
📝 Walkthrough

Walkthrough

CI workflow configuration updated: the determine_changes job now runs on ubuntu-slim instead of ubuntu-latest, and a trailing space is removed from the cargo_check matrix configuration for formatting consistency.

Changes

CI Configuration Update

Layer / File(s) Summary
Runner Optimization
.github/workflows/ci.yaml		 determine_changes job updated to run on ubuntu-slim instead of ubuntu-latest for reduced resource overhead.
Formatting
.github/workflows/ci.yaml		 Whitespace normalization: trailing space removed from include: in cargo_check matrix configuration.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • youknowone

Poem

A slim image lightens the CI load,
Cleaner whitespace marks the road,
Fast workflows without the wait,
This rabbit approves—it's looking great! 🐰✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and concisely summarizes the main change: updating the determine_changes step to run on ubuntu-slim instead of ubuntu-latest.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@fanninpm fanninpm marked this pull request as ready for review May 6, 2026 01:38
@ShaharNaveh

ShaharNaveh commented May 6, 2026

Copy link
Copy Markdown
Contributor

Since the ubuntu-slim image contains the git executable by default, we can use this image and thus improve our actions parallelism.

I like this change, let's see how it playes out for a while.

Ideally, we should consider extracting the cargo_check step into a separate GitHub Actions .yaml file, possibly obviating the need for the determine_changes step.

I was debating it tbh, but I've decided against it because we have some env that we would need to keep synced (CARGO_EXCLUDE, CARGO_ARG and other cargo), once you start separating the workflows too much it becomes a hell to manage:/

ShaharNaveh
ShaharNaveh approved these changes May 6, 2026
View reviewed changes

@ShaharNaveh ShaharNaveh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@youknowone youknowone merged commit 3b36460 into RustPython:main May 6, 2026
25 checks passed
@fanninpm fanninpm deleted the deterime-changes-ubuntu-slim branch May 7, 2026 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShaharNaveh ShaharNaveh ShaharNaveh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fanninpm @ShaharNaveh @youknowone