Fixes SHOULD_NOT_SLEEP() missing situations where sleep is in fact called#472
Open
CabinetOnFire wants to merge 4 commits into
Open
Fixes SHOULD_NOT_SLEEP() missing situations where sleep is in fact called#472CabinetOnFire wants to merge 4 commits into
CabinetOnFire wants to merge 4 commits into
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #356 and finished with some additional tweaks that I noticed while fixing issues I had on /tg/ locally
Fixes #355
Some additional changes on top of that PRs original changes:
The rest is similar, the override tracking system is gone and we now walk the call tree instead. Kept the test case from Cyberboss too (test9)
Also kept the split up test files and improved test helpers.