[JSC][Temporal] Fix double-throw crash in Temporal constructors; clean up stress tests#66884
Open
hyjorc1 wants to merge 1 commit into
Conversation
…n up stress tests https://bugs.webkit.org/show_bug.cgi?id=316793 rdar://179110003 Reviewed by NOBODY (OOPS!). toIntegerWithTruncation() can throw (e.g. when an argument's valueOf triggers JS execution) and return NaN. PlainDate, PlainYearMonth, and PlainMonthDay constructors placed RETURN_IF_EXCEPTION after the !isfinite() guard, so when toIntegerWithTruncation() threw and returned NaN, the isfinite check triggered throwVMRangeError on top of a pending exception, crashing via verifyExceptionCheckNeedIsSatisfied. Fix by moving RETURN_IF_EXCEPTION immediately after each toIntegerWithTruncation() call. Also remove stale //@ skip from temporal-calendar.js, temporal-duration.js, and temporal-timezone.js now that Temporal is complete, and enable the previously-FIXMEd ZonedDateTime.timeZoneId and offset tests in temporal-timezone.js. Test: JSTests/stress/temporal-plainyearmonth-constructor-exception-check.js
Collaborator
|
EWS run on current version of this PR (hash 0594615) Details |
Constellation
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 🧪 jsc-x86-64
🧪 mac-AS-debug-wk2
0594615
0594615