[JSC][Temporal] Fix crash in Temporal.PlainMonthDay.from with very large string input#66887
Open
hyjorc1 wants to merge 1 commit into
Conversation
Collaborator
|
EWS run on previous version of this PR (hash 779631c) Details
|
…rge string input https://bugs.webkit.org/show_bug.cgi?id=316805 rdar://179110736 Reviewed by NOBODY (OOPS!). fromMonthDayString used makeString to include the user-supplied string in the RangeError message. makeString calls WTFCrash on allocation failure, so passing a very large string (e.g. ~2 GB) caused a crash instead of a clean RangeError. Fix by using tryMakeString with a static fallback message, matching the pattern already used in fromYearMonthString. Test: JSTests/stress/temporal-plainmonthday-from-large-string.js
779631c to
e805398
Compare
Collaborator
|
EWS run on current version of this PR (hash e805398) Details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 vision-apple
e805398
e805398