Remove border from search input on 404 page. Fixes #395#443
Conversation
|
Hi @prab18hat, thanks for working on this. There already is a 404 page partial, could you move your code to this file? The focus style could also be updated to match the 404 pages on the rest of the sites, the code for that is here: https://github.com/WordPress/wporg-parent-2021/blob/c1c8d0ee4fd524b35ff885537d1fabd815bcc26e/source/wp-content/themes/wporg-parent-2021/sass/blocks/_search.scss#L132-L143 |
a885b71 to
4a8e0bb
Compare
Changes made as per feedback: Moved search input styles to the existing 404 partial. |
There was a problem hiding this comment.
Thanks @prab18hat! The changes in sass/page/_404.scss look great. Quick check: your description says you removed _404-search.scss, but it looks like that file is still being added in the diff, same rules end up in both files. Was that intentional, or did the force-push not catch the deletion?
Thanks for catching that! The _404-search.scss file was meant to be deleted — looks like the diff didn’t reflect it after the force‑push. I’ve rechecked and pushed the corrected commit now. Everything should be clean and ready to merge. |
|
Going to merge this so it can ship. Quick note: |
This PR removes the border from the search input field on the 404 error page, as requested in issue #395. The change is scoped only to the 404 page using body.error404, so it won’t affect search inputs elsewhere on the site.
What was changed:
Added a new SCSS partial: _404-search.scss targeting the search input on 404 pages.
Imported the partial in the main SCSS manifest so it’s included in the build.
Testing:
After building the theme, visit a 404 page and confirm the search input no longer has a border.
No global styles are affected.