Skip to content

Add regression tests for CJK characters#471

Merged
danwkennedy merged 5 commits into
mainfrom
danwkennedy/cjk-characters
Mar 11, 2026
Merged

Add regression tests for CJK characters#471
danwkennedy merged 5 commits into
mainfrom
danwkennedy/cjk-characters

Conversation

@danwkennedy

@danwkennedy danwkennedy commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

Description

CJK (Chinese/Japanese/Korean) characters can cause failures during download. The latest version of @actions/artifact supports handling them so this PR bumps that dependency and adds a regression test.

@danwkennedy danwkennedy requested a review from a team as a code owner March 10, 2026 19:40
Copilot AI review requested due to automatic review settings March 10, 2026 19:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a CI regression test to ensure artifact upload/download works correctly when artifact names, download paths, and filenames include CJK (Chinese/Japanese/Korean) characters—guarding against prior encoding-related 400 errors from Azure Blob Storage.

Changes:

  • Creates several small test files whose filenames include CJK characters.
  • Uploads each file as its own artifact with a CJK artifact name.
  • Downloads each artifact and verifies the expected files and contents are present.
Comments suppressed due to low confidence (5)

.github/workflows/test.yml:180

  • archive: false is not a recognized input for actions/upload-artifact (at least for the supported @v4 used elsewhere in this repo). Remove it, or if the intent is to minimize compression overhead, use the action’s supported inputs (e.g. compression-level).
        name: CJK-土-${{ matrix.runs-on }}
        path: path/to/cjk-artifacts/file-土.txt
        archive: false

.github/workflows/test.yml:194

  • archive: false is not a recognized input for actions/upload-artifact (at least for the supported @v4 used elsewhere in this repo). Remove it, or if the intent is to minimize compression overhead, use the action’s supported inputs (e.g. compression-level).
        name: CJK-テスト-${{ matrix.runs-on }}
        path: path/to/cjk-artifacts/file-テスト.txt
        archive: false

.github/workflows/test.yml:208

  • archive: false is not a recognized input for actions/upload-artifact (at least for the supported @v4 used elsewhere in this repo). Remove it, or if the intent is to minimize compression overhead, use the action’s supported inputs (e.g. compression-level).
        name: CJK-테스트-${{ matrix.runs-on }}
        path: path/to/cjk-artifacts/file-테스트.txt
        archive: false

.github/workflows/test.yml:187

  • archive: false is not a recognized input for actions/upload-artifact (at least for the supported @v4 used elsewhere in this repo). Remove it, or if the intent is to minimize compression overhead, use the action’s supported inputs (e.g. compression-level).
        name: CJK-中文测试-${{ matrix.runs-on }}
        path: path/to/cjk-artifacts/file-中文测试.txt
        archive: false

.github/workflows/test.yml:201

  • archive: false is not a recognized input for actions/upload-artifact (at least for the supported @v4 used elsewhere in this repo). Remove it, or if the intent is to minimize compression overhead, use the action’s supported inputs (e.g. compression-level).
        name: CJK-東京タワー-${{ matrix.runs-on }}
        path: path/to/cjk-artifacts/file-東京タワー.txt
        archive: false

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +180 to +215
archive: false

- name: Upload CJK artifact - Chinese 中文测试
uses: actions/upload-artifact@v7
with:
name: CJK-中文测试-${{ matrix.runs-on }}
path: path/to/cjk-artifacts/file-中文测试.txt
archive: false

- name: Upload CJK artifact - Japanese テスト
uses: actions/upload-artifact@v7
with:
name: CJK-テスト-${{ matrix.runs-on }}
path: path/to/cjk-artifacts/file-テスト.txt
archive: false

- name: Upload CJK artifact - Japanese 東京タワー
uses: actions/upload-artifact@v7
with:
name: CJK-東京タワー-${{ matrix.runs-on }}
path: path/to/cjk-artifacts/file-東京タワー.txt
archive: false

- name: Upload CJK artifact - Korean 테스트
uses: actions/upload-artifact@v7
with:
name: CJK-테스트-${{ matrix.runs-on }}
path: path/to/cjk-artifacts/file-테스트.txt
archive: false

- name: Upload CJK artifact - Korean 서울시
uses: actions/upload-artifact@v7
with:
name: CJK-서울시-${{ matrix.runs-on }}
path: path/to/cjk-artifacts/file-서울시.txt
archive: false

Copilot AI Mar 10, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

archive: false is not a recognized input for actions/upload-artifact (at least for the supported @v4 used elsewhere in this repo). Remove it, or if the intent is to minimize compression overhead, use the action’s supported inputs (e.g. compression-level).

This issue also appears in the following locations of the same file:

  • line 178
  • line 192
  • line 206
  • line 185
  • line 199
Suggested change
archive: false
- name: Upload CJK artifact - Chinese 中文测试
uses: actions/upload-artifact@v7
with:
name: CJK-中文测试-${{ matrix.runs-on }}
path: path/to/cjk-artifacts/file-中文测试.txt
archive: false
- name: Upload CJK artifact - Japanese テスト
uses: actions/upload-artifact@v7
with:
name: CJK-テスト-${{ matrix.runs-on }}
path: path/to/cjk-artifacts/file-テスト.txt
archive: false
- name: Upload CJK artifact - Japanese 東京タワー
uses: actions/upload-artifact@v7
with:
name: CJK-東京タワー-${{ matrix.runs-on }}
path: path/to/cjk-artifacts/file-東京タワー.txt
archive: false
- name: Upload CJK artifact - Korean 테스트
uses: actions/upload-artifact@v7
with:
name: CJK-테스트-${{ matrix.runs-on }}
path: path/to/cjk-artifacts/file-테스트.txt
archive: false
- name: Upload CJK artifact - Korean 서울시
uses: actions/upload-artifact@v7
with:
name: CJK-서울시-${{ matrix.runs-on }}
path: path/to/cjk-artifacts/file-서울시.txt
archive: false
compression-level: 0
- name: Upload CJK artifact - Chinese 中文测试
uses: actions/upload-artifact@v7
with:
name: CJK-中文测试-${{ matrix.runs-on }}
path: path/to/cjk-artifacts/file-中文测试.txt
compression-level: 0
- name: Upload CJK artifact - Japanese テスト
uses: actions/upload-artifact@v7
with:
name: CJK-テスト-${{ matrix.runs-on }}
path: path/to/cjk-artifacts/file-テスト.txt
compression-level: 0
- name: Upload CJK artifact - Japanese 東京タワー
uses: actions/upload-artifact@v7
with:
name: CJK-東京タワー-${{ matrix.runs-on }}
path: path/to/cjk-artifacts/file-東京タワー.txt
compression-level: 0
- name: Upload CJK artifact - Korean 테스트
uses: actions/upload-artifact@v7
with:
name: CJK-테스트-${{ matrix.runs-on }}
path: path/to/cjk-artifacts/file-테스트.txt
compression-level: 0
- name: Upload CJK artifact - Korean 서울시
uses: actions/upload-artifact@v7
with:
name: CJK-서울시-${{ matrix.runs-on }}
path: path/to/cjk-artifacts/file-서울시.txt
compression-level: 0

Copilot uses AI. Check for mistakes.
shell: bash
run: |
mkdir -p path/to/cjk-artifacts
# Chinese - 土 (U+571F) known to fail, 日 (U+65E5) known to work

Copilot AI Mar 10, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment mentions testing 日 (U+65E5) as a known-working CJK character, but the workflow doesn’t actually create/upload/download any artifact or file containing 日. Either add a 日 case to the regression tests or remove the mention to avoid misleading documentation.

Suggested change
# Chinese - 土 (U+571F) known to fail, 日 (U+65E5) known to work
# Chinese - 土 (U+571F) known to fail in past regression

Copilot uses AI. Check for mistakes.
@danwkennedy danwkennedy force-pushed the danwkennedy/cjk-characters branch from e4f816e to e944264 Compare March 11, 2026 15:00
@danwkennedy danwkennedy merged commit 3e5f45b into main Mar 11, 2026
11 checks passed
@danwkennedy danwkennedy deleted the danwkennedy/cjk-characters branch March 11, 2026 15:35
mergify Bot added a commit to ArcadeData/arcadedb that referenced this pull request Mar 13, 2026
Bumps the github-actions group with 2 updates: [anthropics/claude-code-action](https://github.com/anthropics/claude-code-action) and [actions/download-artifact](https://github.com/actions/download-artifact).
Updates `anthropics/claude-code-action` from 1.0.70 to 1.0.71
Release notes

*Sourced from [anthropics/claude-code-action's releases](https://github.com/anthropics/claude-code-action/releases).*

> v1.0.71
> -------
>
> What's Changed
> --------------
>
> * docs: warn that allowed\_bots can expose the action to external triggers by [`@​an-dustin`](https://github.com/an-dustin) in [anthropics/claude-code-action#1039](https://redirect.github.com/anthropics/claude-code-action/pull/1039)
> * feat(inline-comment): add confirmed param + probe-pattern safety net by [`@​km-anthropic`](https://github.com/km-anthropic) in [anthropics/claude-code-action#1048](https://redirect.github.com/anthropics/claude-code-action/pull/1048)
>
> New Contributors
> ----------------
>
> * [`@​an-dustin`](https://github.com/an-dustin) made their first contribution in [anthropics/claude-code-action#1039](https://redirect.github.com/anthropics/claude-code-action/pull/1039)
>
> **Full Changelog**: <anthropics/claude-code-action@v1...v1.0.71>


Commits

* [`5d0cc74`](anthropics/claude-code-action@5d0cc74) feat(inline-comment): add confirmed param + probe-pattern safety net ([#1048](https://redirect.github.com/anthropics/claude-code-action/issues/1048))
* [`567be3d`](anthropics/claude-code-action@567be3d) chore: bump Claude Code to 2.1.73 and Agent SDK to 0.2.73
* [`eb99fb3`](anthropics/claude-code-action@eb99fb3) chore: bump Claude Code to 2.1.72 and Agent SDK to 0.2.72
* [`33fbb80`](anthropics/claude-code-action@33fbb80) docs: warn that allowed\_bots can expose the action to external triggers ([#1039](https://redirect.github.com/anthropics/claude-code-action/issues/1039))
* [`3428ca8`](anthropics/claude-code-action@3428ca8) chore: bump Claude Code to 2.1.71 and Agent SDK to 0.2.71
* See full diff in [compare view](anthropics/claude-code-action@26ec041...5d0cc74)
  
Updates `actions/download-artifact` from 8.0.0 to 8.0.1
Release notes

*Sourced from [actions/download-artifact's releases](https://github.com/actions/download-artifact/releases).*

> v8.0.1
> ------
>
> What's Changed
> --------------
>
> * Support for CJK characters in the artifact name by [`@​danwkennedy`](https://github.com/danwkennedy) in [actions/download-artifact#471](https://redirect.github.com/actions/download-artifact/pull/471)
> * Add a regression test for artifact name + content-type mismatches by [`@​danwkennedy`](https://github.com/danwkennedy) in [actions/download-artifact#472](https://redirect.github.com/actions/download-artifact/pull/472)
>
> **Full Changelog**: <actions/download-artifact@v8...v8.0.1>


Commits

* [`3e5f45b`](actions/download-artifact@3e5f45b) Add regression tests for CJK characters ([#471](https://redirect.github.com/actions/download-artifact/issues/471))
* [`e6d03f6`](actions/download-artifact@e6d03f6) Add a regression test for artifact name + content-type mismatches ([#472](https://redirect.github.com/actions/download-artifact/issues/472))
* See full diff in [compare view](actions/download-artifact@70fc10c...3e5f45b)
  
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
Dependabot commands and options
  
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot show  ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore  major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
- `@dependabot ignore  minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
- `@dependabot ignore ` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore ` will remove all of the ignore conditions of the specified dependency
- `@dependabot unignore  ` will remove the ignore condition of the specified dependency and ignore conditions
tae898 pushed a commit to humemai/arcadedb-embedded-python that referenced this pull request Jun 28, 2026
Bumps the github-actions group with 2 updates: [anthropics/claude-code-action](https://github.com/anthropics/claude-code-action) and [actions/download-artifact](https://github.com/actions/download-artifact).
Updates `anthropics/claude-code-action` from 1.0.70 to 1.0.71
Release notes

*Sourced from [anthropics/claude-code-action's releases](https://github.com/anthropics/claude-code-action/releases).*

> v1.0.71
> -------
>
> What's Changed
> --------------
>
> * docs: warn that allowed\_bots can expose the action to external triggers by [`@​an-dustin`](https://github.com/an-dustin) in [anthropics/claude-code-action#1039](https://redirect.github.com/anthropics/claude-code-action/pull/1039)
> * feat(inline-comment): add confirmed param + probe-pattern safety net by [`@​km-anthropic`](https://github.com/km-anthropic) in [anthropics/claude-code-action#1048](https://redirect.github.com/anthropics/claude-code-action/pull/1048)
>
> New Contributors
> ----------------
>
> * [`@​an-dustin`](https://github.com/an-dustin) made their first contribution in [anthropics/claude-code-action#1039](https://redirect.github.com/anthropics/claude-code-action/pull/1039)
>
> **Full Changelog**: <anthropics/claude-code-action@v1...v1.0.71>


Commits

* [`5d0cc74`](anthropics/claude-code-action@5d0cc74) feat(inline-comment): add confirmed param + probe-pattern safety net ([#1048](https://redirect.github.com/anthropics/claude-code-action/issues/1048))
* [`567be3d`](anthropics/claude-code-action@567be3d) chore: bump Claude Code to 2.1.73 and Agent SDK to 0.2.73
* [`eb99fb3`](anthropics/claude-code-action@eb99fb3) chore: bump Claude Code to 2.1.72 and Agent SDK to 0.2.72
* [`33fbb80`](anthropics/claude-code-action@33fbb80) docs: warn that allowed\_bots can expose the action to external triggers ([ArcadeData#1039](https://redirect.github.com/anthropics/claude-code-action/issues/1039))
* [`3428ca8`](anthropics/claude-code-action@3428ca8) chore: bump Claude Code to 2.1.71 and Agent SDK to 0.2.71
* See full diff in [compare view](anthropics/claude-code-action@26ec041...5d0cc74)
  
Updates `actions/download-artifact` from 8.0.0 to 8.0.1
Release notes

*Sourced from [actions/download-artifact's releases](https://github.com/actions/download-artifact/releases).*

> v8.0.1
> ------
>
> What's Changed
> --------------
>
> * Support for CJK characters in the artifact name by [`@​danwkennedy`](https://github.com/danwkennedy) in [actions/download-artifact#471](https://redirect.github.com/actions/download-artifact/pull/471)
> * Add a regression test for artifact name + content-type mismatches by [`@​danwkennedy`](https://github.com/danwkennedy) in [actions/download-artifact#472](https://redirect.github.com/actions/download-artifact/pull/472)
>
> **Full Changelog**: <actions/download-artifact@v8...v8.0.1>


Commits

* [`3e5f45b`](actions/download-artifact@3e5f45b) Add regression tests for CJK characters ([ArcadeData#471](https://redirect.github.com/actions/download-artifact/issues/471))
* [`e6d03f6`](actions/download-artifact@e6d03f6) Add a regression test for artifact name + content-type mismatches ([ArcadeData#472](https://redirect.github.com/actions/download-artifact/issues/472))
* See full diff in [compare view](actions/download-artifact@70fc10c...3e5f45b)
  
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
Dependabot commands and options
  
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot show  ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore  major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
- `@dependabot ignore  minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
- `@dependabot ignore ` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore ` will remove all of the ignore conditions of the specified dependency
- `@dependabot unignore  ` will remove the ignore condition of the specified dependency and ignore conditions
ziemowit-orlikowski added a commit to Elmnt-Internal/download-artifact that referenced this pull request Jul 1, 2026
* docs: small migration fix

* Update MIGRATION.md

Fixing the broken link pointing to `actions/upload-artifact` content outside of the repository.

cc: @pedrolacerda

* Update artifact package to 2.2.2

* Bump artifact version, do digest check

* Refactor loop

* update dist

* Refactor loop, break for testing

* unbreak testing code

* Break the thing, also log the expected digest

* run release

* Make work as intended

* Update README.md

removing deprecation warning

* Bump artifact package

* Update artifact license

* Update artifact to 2.3.2

* Update dist

* Fix bug introduced in 4.2.0

* dist & package.json

* Add tests & test dependencies

* Lint

* Unfix error

* Configure tsconfig

* lint

* Add extra assertion to download single artifact test

* lint

* Run unit tests in CI

* Move log statements

* implement new `artifact-ids` input

* apply actions#401 (comment) suggestion

* when only one artifact-id is given, use `getArtifact` and check the resulting id returned

* bundle

* use the same `artifactClient.getArtifact` structure as seen above in `isSingleArtifactDownload` logic

* bundle

* revert `getArtifact()` changes - for now we have to list and filter by artifact-ids until a `getArtifactById()` public method exists

* add supporting unit tests for artifact downloads with ids

* Fix workflow example for downloading by artifact ID

* Remove path filters from Check dist workflow

* prep for v4.3.0 release

* Update README.md

* Update to Node.js 24 and related dependencies

Bump Node.js version to 24 in workflows, action definition, and package requirements. Update @types/node to 24.1.0 and add engines field to enforce Node.js >=24. This ensures compatibility with the latest Node.js features and ecosystem.

* fix download path logic when downloading a single artifact by id

* update docs

* bundle dist

* refactor: resolve download path correctly in artifact download tests (mainly for windows unit tests)

* Update README for download-artifact v5 changes

Updated documentation for download-artifact action to reflect changes in version 5.

* Update README.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Remove migration guide for artifact download changes

Readme probably should be less verbose since it's not a changelog.

* Update README with artifact extraction details

Clarified note on artifact extraction and GHES support.

* Readme: spell out the first use of GHES

* Update to use local artifact package v3.0.0

- Switch from @actions/artifact@^2.3.2 to file:../packages/artifact
- Add uri-js-replace security override
- Update @actions/github to v6.0.1 for security fixes
- Rebuild dist/index.js with updated dependencies
- Fix all security vulnerabilities (0 remaining)

* update licenses

* Update licensed configuration for new dependencies with Node 24 support

* Fix licensed configuration by ignoring packages with missing license text

* update

* Update licensed workflow to cache dependencies before status check

* Revert licensed workflow changes - keep original behavior

* update licences with temp not using package

* update dist

* Prepare `v6.0.0`

* Remove `github.dep.yml`

* Revert "Remove `github.dep.yml`"

This reverts commit bb3a066.

* Update GHES guidance to include reference to Node 20 version

* Fix typo in URL

* chore: use local @actions/artifact and @actions/core packages

* chore: update dependencies to use published npm packages

* chore: update @actions/artifact to use npm package v5.0.0

- Changed from file:../packages/artifact to 5.0.0
- Regenerated package-lock.json

* chore: regenerate license cache and fix @bufbuild/protobuf license

* chore: add minimatch.dep.yml license file

* chore: use local @actions/artifact package for Node.js 24 testing

This branch uses a local file reference to @actions/artifact which includes
the updated @azure/storage-blob ^12.29.1 to fix the punycode deprecation
warning on Node.js 24.

This is a test branch - do not merge until @actions/artifact@5.0.1 is published.

* fix: update @actions/artifact to ^5.0.0 for Node.js 24 punycode fix

Updates @actions/artifact dependency to use the published npm version
which includes @azure/storage-blob ^12.29.1 that fixes the punycode
deprecation warning on Node.js 24.

* chore: update package-lock.json with @actions/artifact@5.0.1

* chore: update @actions/artifact license file to 5.0.1

* chore: remove obsolete dependency license files

* chore: restore minimatch.dep.yml license file

* chore: release v7.0.0 for Node.js 24 support

- Update to Node.js 24 runtime (runs.using: node24)
- Bump version to 7.0.0
- Update README with v7 release notes
- Rebuild dist

* doc: update readme

* Update .gitignore

* Migrate eslint to `v9`

* Upgrade jest and typescript

* Don't attempt to un-zip non-zipped downloads

* Add tests

* Add an integration test for `skip-decompress`

* Update the integration test

* Cache licenses

* Updated the licensed version

* Revert "Updated the licensed version"

This reverts commit e6afc5e.

* Re-add minimatch.dep.yml

* Fixup the minimatch license

* Fix skip decompress test

* One more test fix

* Update test names to make it clearer what they do

* Bump the version to `v8` and add release notes

* Add note about package bumps

* Add a setting to specify what to do on hash mismatch and default it to `error`

* Fix linting issues

* Add change docs

* Add a regression test for artifact name + content-type mismatches (actions#472)

* Add a regression test for artifact name + content-type mismatches

* Specify that we want v4 in a comment

* Fix the expected type

* Add regression tests for CJK characters (actions#471)

* Add regression tests for CJK characters

* Dedupe the names and remove the ignored `name` param

* Bump @actions/artifact to v6.2.1

* Run `npm run release`

* Update licenses

* Update the readme (actions#473)

* Update the readme

* Update upload artifact versions

* Add back the GHES support note

* Update the skip-decompress description

* Be more specific with the direct download example

* Add GHES support section to TOC

---------

Co-authored-by: Francisco Robles Martín <f.robles.martin@pm.me>
Co-authored-by: Josh Gross <joshmgross@github.com>
Co-authored-by: Andy Feller <andyfeller@github.com>
Co-authored-by: Rob Herley <robherley@github.com>
Co-authored-by: Yang Cao <yacaovsnc@github.com>
Co-authored-by: Ryan Ghadimi <114221941+GhadimiR@users.noreply.github.com>
Co-authored-by: Larissa Fortuna <56982181+lkfortuna@users.noreply.github.com>
Co-authored-by: JoannaaKL <joannaakl@github.com>
Co-authored-by: Grant Birkinbine <grant.birkinbine@gmail.com>
Co-authored-by: Ben De St Paer-Gotch <nebuk89@github.com>
Co-authored-by: Salman Muin Kayser Chishti <salmanmkc@github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Daniel Kennedy <danwkennedy@github.com>
Co-authored-by: Patrik Polyak <patrikpolyak@github.com>
Co-authored-by: Zachary Taylor <zaataylor@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants