Kaminari#116
Conversation
|
Hey thanks. I actually think that we should pick one. I don't have any issue with us switching to Kaminari if the community's behind it. I do like how Kaminari works better than will_paginate. Thoughts? |
|
Good idea, It's the first thing i checked in the code my self. I tried kaminari on a couple of apps i upgraded and it's very nice to work with. |
|
+1 for kaminari. it looks a lot more active lately. apart from the arguments already listed, will_paginate don't work with rails 3.1 till now(and since the last commit was at october, 2010, I think they don't have any plans on it). |
|
+1 Kaminari |
|
+1 Kaminari |
|
+1 kaminari For wider adoption of active_admin, it is best to go with tools that already support other orms like kaminari. |
|
+1 for kaminari replacing will_paginate |
|
+1 I like Kaminari too |
|
So I think we should just remove will_paginate and replace it with Kaminari. @mwindwer do you have time to modify the pull request for this? Otherwise I can tackle over the next couple of days. |
|
Just removed will_paginate completely. All cucumber tests are passing. |
|
Sweet! Thanks for rocking on this @mwindwer. I'll get a chance to merge this to master tomorrow morning. |
|
w00t!! |
|
@amatsuda hey thanks for a great project! We'll definitely keep in touch if there's anything we need. So far things have been pretty seamless. |
I added support for pagination with Kaminari if a rails project is using it. The advantage of kaminari is that it works with mongoid and other ORMs. If Kaminari is not being used, the default will_paginate implementation will still work.
P.S. I'm going to be taking a stab at getting activeadmin playing nicely with mongoid (and possibly other ORMs via orm_adapter). I think the most difficult task will be getting a meta_search implementation that will work. Any ideas?