Skip to content

Move all jruby travis builds to allow_failures section#5112

Merged
varyonic merged 1 commit into
activeadmin:masterfrom
javierjulio:allow-jruby-failures
Jul 29, 2017
Merged

Move all jruby travis builds to allow_failures section#5112
varyonic merged 1 commit into
activeadmin:masterfrom
javierjulio:allow-jruby-failures

Conversation

@javierjulio

@javierjulio javierjulio commented Jul 28, 2017

Copy link
Copy Markdown
Member

As we discussed that we'd move this to the allow_failures section. I just had another travis failure because the jruby rails42 build is failing in #5081. 😩 Sorry @deivid-rodriguez. 😞

@deivid-rodriguez deivid-rodriguez left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think at this point you can just say rmv: jruby-9.1.12.0 under allowed_failures. You don't need to specify every gemfile.

@javierjulio

javierjulio commented Jul 29, 2017

Copy link
Copy Markdown
Member Author

@deivid-rodriguez cool, I just made that change but I don't see any builds for jruby so it means its not running them at all since it doesn't know what Gemfile to use. You can see that here: https://travis-ci.org/activeadmin/activeadmin/builds/258772337 I'll delete the second commit.

In fact it wasn't showing up for the previous change either. I don't think it'll run it to begin with if its all in the allow_failures section. At least I don't see anything in Travis for it. Let me know what you prefer, keep the original commit or make the change you requested.

@javierjulio javierjulio force-pushed the allow-jruby-failures branch from bdf5837 to 6a8b1c3 Compare July 29, 2017 01:24
Comment thread .travis.yml
- bundle exec rake docs:build

rvm:
- jruby-9.1.12.0

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to restore this entry I think. Otherwise it won't run any jruby build, indeed.

@varyonic varyonic force-pushed the allow-jruby-failures branch from 6a8b1c3 to f38f5ff Compare July 29, 2017 17:25
@varyonic varyonic merged commit 6b8c072 into activeadmin:master Jul 29, 2017
@varyonic

Copy link
Copy Markdown
Contributor

I pushed this through as it appears Travis moved us to Trusty and broke the build for JRuby. There may be other fixes available but this was simplest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants