-
Notifications
You must be signed in to change notification settings - Fork 0
Dropdown: reveal the current value on open + proper listbox/menu item roles #396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
acusti
wants to merge
6
commits into
main
Choose a base branch
from
dropdown-highlight-selected-value
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
126c785
Reveal the current value when the dropdown opens
acusti 13a9f7f
Add listbox and menu item roles
acusti 495b2fd
Keep aria-selected on the submitted item when the body stays open
claude c48606a
Document item roles, reveal-on-open, and the selected tint in the README
claude 08cddbf
Document the reveal-on-open scope precisely
claude 6238202
Never write invalid or conflicting selection ARIA in a listbox
claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Reveal the current value when the dropdown opens
A controlled dropdown opened at the top of its list regardless of the current value. On open, mark the item whose data-ukt-value matches props.value aria-selected, make it the active item so keyboard navigation starts there, and scroll it into view — so a long list opens showing, and scrolled to, the current selection. setActiveItem's event becomes optional (it only builds the onActiveItem payload, which is skipped when there's no event) so an item can be activated programmatically on open. Adds a themeable --uktdd-body-bg-color-selected tint for the persistent selection marker. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
- Loading branch information
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| --- | ||
| '@acusti/dropdown': minor | ||
| --- | ||
|
|
||
| Reveal the current value when the dropdown opens | ||
|
|
||
| A controlled dropdown now opens with the item whose `data-ukt-value` | ||
| matches `props.value` marked `aria-selected`, made the active item (so | ||
| keyboard navigation starts from it), and scrolled into view — so a long | ||
| list opens showing, and scrolled to, the current selection instead of the | ||
| top. The persistent selection tint is themeable via the new | ||
| `--uktdd-body-bg-color-selected` custom property. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.