Skip to content

feat(csv-parse): implement TransformStream #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wdavidw merged 6 commits into from
Nov 20, 2024
Merged

feat(csv-parse): implement TransformStream #445

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4e96544
feat(csv-parse): implement TransformStream
uasan Nov 18, 2024
8a2d623
feat(csv-parse): add test api.web_stream and fix controller.terminate
uasan Nov 18, 2024
6888830
feat(csv-parse): added errors handle to TransformStream
uasan Nov 20, 2024
d33a61a
test(csv-parse): error thrown by webstream
wdavidw Nov 20, 2024
ecaf946
build(csv-parse): exclude web_stream ts test from ci in node 14
wdavidw Nov 20, 2024
1f763d0
fix(csv-parse): satisfy test and re-habilitate node stream import
wdavidw Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test(csv-parse): error thrown by webstream
  • Loading branch information
@wdavidw
wdavidw committed Nov 20, 2024
commit d33a61a8a575f8a48545fc7e20fc56221ad339dc
28 changes: 21 additions & 7 deletions packages/csv-parse/test/api.web_stream.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,31 +1,45 @@
import assert from 'assert';
import 'should'
import {parse as parseStream} from '../lib/stream.js'
import { CsvError } from '../lib/index.js'

describe('API Web Stream', () => {

describe('stream/web/TransformStream', () => {

it('simple parse', async () => {
const stream = parseStream();

const writer = stream.writable.getWriter();
const reader = stream.readable.getReader();

await writer.write(Buffer.from("A,B,C\nD,E,F"));
await writer.close();

assert.deepStrictEqual(await reader.read(), {
await reader.read().should.finally.eql({
done: false,
value: ['A', 'B', 'C'],
});
assert.deepStrictEqual(await reader.read(), {
await reader.read().should.finally.eql({
done: false,
value: ['D', 'E', 'F'],
});
assert.deepStrictEqual(await reader.read(), {
await reader.read().should.finally.eql({
done: true,
value: undefined,
});
})

it("cat error parse", async function () {
const stream = parseStream();
const writer = stream.writable.getWriter();
try {
await writer.write(Buffer.from("A,B,C\nD,E"));
await writer.close();
throw Error("Shall not be called");
} catch (err) {
if (!(err instanceof CsvError)) {
throw Error("Invalid error type");
}
err.code.should.eql("CSV_RECORD_INCONSISTENT_FIELDS_LENGTH");
}
});

})
})