Notifier._build_context(): mod.__version__ is outdated#273
Open
der-flo wants to merge 1 commit into
Open
Conversation
…ages I changed `Notifier._build_context()` to use `importlib.metadata.version()` instead of `__version__`, loosely based on airbrake#269 See https://peps.python.org/pep-0396/, https://packaging.python.org/en/latest/discussions/versioning/#runtime-version-access, https://packaging.python.org/en/latest/discussions/single-source-version/#single-source-version Maybe solves airbrake#269
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notifier._build_context():mod.__version__is outdated and leads to warnings with multiple packages:I changed it to use
importlib.metadata.version()instead of__version__. It is loosely based on the solution in #269.See https://peps.python.org/pep-0396/, https://packaging.python.org/en/latest/discussions/versioning/#runtime-version-access, https://packaging.python.org/en/latest/discussions/single-source-version/#single-source-version for background information
Maybe solves #269
It would be nice, if you merge my or similar changes and release a new version of the package. Thanks!