Skip to content

[support/4.x] Pin GitHub actions/setup-node to v3.6.0#3909

Merged
colinrotherham merged 1 commit into
support/4.xfrom
pin-setup-node
Jul 6, 2023
Merged

[support/4.x] Pin GitHub actions/setup-node to v3.6.0#3909
colinrotherham merged 1 commit into
support/4.xfrom
pin-setup-node

Conversation

@colinrotherham

@colinrotherham colinrotherham commented Jul 6, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Rolling back to unblock the release

Workaround for an npm cache path issue throwing the error:

Post job cleanup.
Error: Cache folder paths are not retrieved for npm with cache-dependency-path =

This is because our "warm" test runs have node_modules cached already so we configure actions/setup-node to skip cache restoration for the npm get cache directory as we don't need it (and it's slow to restore on Windows):

with:
  cache: ${{ inputs.use-cache != 'false' && 'npm' || '' }}
  node-version-file: .nvmrc

This tip was documented in Usage:

# Used to specify a package manager for caching in the default directory. Supported values: npm, yarn, pnpm.
# Package manager should be pre-installed
# Default: ''
cache: ''

@colinrotherham colinrotherham requested a review from a team as a code owner July 6, 2023 10:13
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3909 July 6, 2023 10:13 Inactive
@colinrotherham
Pin GitHub actions/setup-node to v3.6.0
66c58f9 
Rolling back to unblock the release

Workaround for an npm cache path issue throwing the error:

```
Post job cleanup.
Error: Cache folder paths are not retrieved for npm with cache-dependency-path =
```
@colinrotherham colinrotherham changed the title Pin GitHub actions/setup-node to v3.6 Pin GitHub actions/setup-node to v3.6.0 Jul 6, 2023
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3909 July 6, 2023 10:15 Inactive
@colinrotherham colinrotherham added this to the v4.7.0 milestone Jul 6, 2023
@colinrotherham colinrotherham added 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) github-actions labels Jul 6, 2023
@colinrotherham colinrotherham merged commit e44e967 into support/4.x Jul 6, 2023
@colinrotherham colinrotherham deleted the pin-setup-node branch July 6, 2023 10:19
@36degrees 36degrees mentioned this pull request Jul 6, 2023
Merged
@36degrees 36degrees changed the title Pin GitHub actions/setup-node to v3.6.0 [support/4.x] Pin GitHub actions/setup-node to v3.6.0 Jul 6, 2023
@colinrotherham colinrotherham mentioned this pull request Jul 6, 2023
Closed
5 tasks
@colinrotherham

colinrotherham commented Jul 6, 2023

Copy link
Copy Markdown
Contributor Author

Raised an issue:

@colinrotherham colinrotherham added the github_actions Pull requests that update GitHub Actions code label Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@owenatgov owenatgov owenatgov approved these changes

Assignees

No one assigned

Labels

🐛 bug Something isn't working the way it should (including incorrect wording in documentation) github_actions Pull requests that update GitHub Actions code

Projects

GOV.UK Design System cycle board
Archived in project

Milestone

v4.7.0

Development

Successfully merging this pull request may close these issues.

3 participants

@colinrotherham @owenatgov @govuk-design-system-ci