fix(migrations): resolve migration failure when tsconfig specifies rootDir#69194
Open
aparzi wants to merge 1 commit into
Open
fix(migrations): resolve migration failure when tsconfig specifies rootDir#69194aparzi wants to merge 1 commit into
aparzi wants to merge 1 commit into
Conversation
…otDir When `rootDir` was set in a project's tsconfig (e.g. `rootDir: "src"`), tsurge-based migrations would fail because `projectRoot` was derived from `rootDir`, causing `rootRelativePath` to be computed relative to `src/` instead of the workspace root. This produced paths like `app/app.ts` instead of `src/app/app.ts`, which the DevKit tree could not resolve. Fix by overriding `info.projectRoot` to `fs.pwd()` (always `/` in the DevKit filesystem) immediately after program creation, ensuring workspace-relative paths are used for all tree updates.
2311352 to
dfd93a5
Compare
alan-agius4
reviewed
Jun 8, 2026
alan-agius4
left a comment
Contributor
There was a problem hiding this comment.
I briefly synced with @devversion about this, and it’s considered risky, so we’ll need to run some additional verifications.
Furthermore, this approach doesn't support cases where the tsconfig is located outside the root directory, as rootDirs are resolved relative to the tsconfig location and hence using the fw.pwd() doesn't seem correct.
Regardless, did a quick check and potentially the changes should probably be implemented within getProgramInfoFromBaseInfo rather than mutating the info object directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
rootDirwas set in a project's tsconfig (e.g.rootDir: "src"), tsurge-based migrations would fail becauseprojectRootwas derived fromrootDir, causingrootRelativePathto be computed relative tosrc/instead of the workspace root. This produced paths likeapp/app.tsinstead ofsrc/app/app.ts, which the DevKit tree could not resolve.Fix by overriding
info.projectRoottofs.pwd()(always/in the DevKit filesystem) immediately after program creation, ensuring workspace-relative paths are used for all tree updates.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?