Skip to content

test: fixed package-lock#436

Merged
Jefiozie merged 1 commit into
mainfrom
test_angulapr_eslint
May 2, 2024
Merged

test: fixed package-lock#436
Jefiozie merged 1 commit into
mainfrom
test_angulapr_eslint

Conversation

@SanderElias

@SanderElias SanderElias commented Apr 30, 2024

Copy link
Copy Markdown
Contributor

related to issue #435

This package-lock should work on windows. Awaiting result form that.

@SanderElias

Copy link
Copy Markdown
Contributor Author

@Harpush @Jefiozie Can you test if npm install works for this branch?

@Harpush

Harpush commented Apr 30, 2024

Copy link
Copy Markdown
Collaborator

@SanderElias After nuking node_modules and trying a clean npm install - seems to work!

@SanderElias SanderElias marked this pull request as ready for review May 1, 2024 04:18
@SanderElias SanderElias requested review from Harpush and Jefiozie May 1, 2024 04:18

@Jefiozie Jefiozie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jefiozie Jefiozie merged commit 8fc540e into main May 2, 2024
@Jefiozie Jefiozie deleted the test_angulapr_eslint branch May 2, 2024 07:33
@Jefiozie

Jefiozie commented Feb 2, 2025

Copy link
Copy Markdown
Contributor

@all-contributors please add @SanderElias for test.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

@allcontributors

Copy link
Copy Markdown
Contributor

@Jefiozie

I've put up a pull request to add @SanderElias! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants