Skip to content

Updated is_of_type() check to work better with Python 3#57

Merged
saturnboy merged 1 commit into
assertpy:masterfrom
skippyprime:metaclasses
Aug 13, 2016
Merged

Updated is_of_type() check to work better with Python 3#57
saturnboy merged 1 commit into
assertpy:masterfrom
skippyprime:metaclasses

Conversation

@skippyprime

Copy link
Copy Markdown
Contributor

The metaclass check was failing for me on some python 3 testing environments with tox. All tests passing.

@coveralls

coveralls commented Aug 8, 2016

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 99.431% when pulling f10de79 on skippyprime:metaclasses into 3d0fd62 on ActivisionGameScience:master.

@saturnboy

Copy link
Copy Markdown
Contributor

@skippyprime thanks! I guess I probably should have used issubclass() in the first place

@saturnboy saturnboy merged commit 4e8b057 into assertpy:master Aug 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants