Skip to content

fixed git submodule bug when using relative paths #12156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
charliermarsh merged 17 commits into from
May 14, 2026
Merged

fixed git submodule bug when using relative paths #12156

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
4d1b53a
fixed git submodule bug and added tests
Choudhry18 Mar 13, 2025
680ba31
changed the approach now resetting before updating submodules
Choudhry18 Mar 15, 2025
4fb6bdd
reset before submodule update, adding test and updating comments
Choudhry18 Mar 16, 2025
001048c
removed large file from test
Choudhry18 Mar 16, 2025
e561ffd
taking out the test that isn't directly related
Choudhry18 Mar 17, 2025
d3ff937
changed the error message for a test
Choudhry18 Jan 26, 2026
04cab09
removed a unused_self that is no longer needed
Choudhry18 Jan 26, 2026
f76249a
Merge branch 'main' into git_sub_modules
charliermarsh May 14, 2026
28f5f4b
Merge branch 'main' into git_sub_modules
charliermarsh May 14, 2026
6d31341
Avoid persistence; use our own repo
charliermarsh May 14, 2026
8773c4c
Add RustDoc
charliermarsh May 14, 2026
b730622
Do this recursively
charliermarsh May 14, 2026
6c32ee3
Merge branch 'main' into git_sub_modules
woodruffw May 14, 2026
acfd222
Re-enable tests
woodruffw May 14, 2026
ea5f03c
Remove duplicate test
charliermarsh May 14, 2026
670622c
Merge branch 'main' into git_sub_modules
charliermarsh May 14, 2026
e0a0eb1
Add a remote relative submodule test
woodruffw May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Re-enable tests 
Signed-off-by: William Woodruff <william@yossarian.net>
  • Loading branch information
@woodruffw
woodruffw committed May 14, 2026
commit acfd2224fc191fdb938c1534096810b5955caee4
1 change: 0 additions & 1 deletion crates/uv-git/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ license = { workspace = true }

[lib]
doctest = false
test = false

@woodruffw woodruffw May 14, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed the uv-git tests weren't running, thanks to our new astral-bot automation 🙂


[lints]
workspace = true
Expand Down
Loading